1528199 - XUL trees flush at an inappropriate time.

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

There's a bit of orange in my try push for the assertions patch for bug 1525509, because XUL trees already do insane stuff.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: stack

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1528199 - Make nsTreeColFrame::InvalidateColumns not flush. r=dholbert,TYLin

That's not sound.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Can I have a sec rating for this? I think it's not more than sec-moderate, since it only affects XUL trees and we don't have any of that in content.

Comment 4

[Daniel Veditz [:dveditz]]

Sounds right.

Comment 5

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/mozilla-central/rev/3f18f4d9dc1e

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9044156 [details]
Bug 1528199 - Make nsTreeColFrame::InvalidateColumns not flush. r=dholbert,TYLin

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Not a regression

User impact if declined

Can't land the assertions in bug 1525509.

Is this code covered by automated tests?

Unknown

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Straight-forward patch affecting only XUL trees that allows the assertions from bug 1525509 to hold.

String changes made/needed

none

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9044156 [details]
Bug 1528199 - Make nsTreeColFrame::InvalidateColumns not flush. r=dholbert,TYLin

Fix for sec-moderate issue plus we need this for bug 1525509.
OK for uplift for beta 10.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/42c46d6cd486