1528266 - [wpt-sync] Sync PR 15413 - Simplify test_driver_internal to not use prototype + Object.create

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 15413 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15413
Details from upstream follow.

Philip Jägenstedt <[e-mail]> wrote:

Simplify test_driver_internal to not use prototype + Object.create

Context: https://github.com/web-platform-tests/wpt/pull/11173/files#r236038149

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 15413 applied with additional changes from upstream: bfd9504d321d35ebfbbe56ab6c7f5c0642495719

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d8d7b3c600ffca3abecc5b7906e6259dd821fee

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=400127587e4bac8f1b6c26060fd8b570b9382d69

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 252 tests and 466 subtests
OK     : 218[linux32-opt,linux64-debug,linux64-opt], 219[linux32-debug]
PASS   : 144[linux32-debug], 151[linux32-opt,linux64-debug,linux64-opt]
FAIL   : 281[linux32-opt,linux64-debug,linux64-opt], 290[linux32-debug]
TIMEOUT: 44[linux32-debug], 46[linux32-opt,linux64-debug,linux64-opt]
ERROR  : 14
NOTRUN : 2[linux32-debug], 3[linux32-opt,linux64-debug,linux64-opt]

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/payment-request/payment-request-abort-method.https.html
    Calling abort() multiple times is always a new object.: FAIL[linux32-debug]
    Throws if the promise [[state]] is not "interactive": FAIL[linux32-debug]
/payment-request/payment-request-canmakepayment-method-protection.https.html
    Optionally, at the user agent's discretion, return a promise rejected with a "NotAllowedError" DOMException.: FAIL[linux32-debug]
/payment-request/payment-request-canmakepayment-method.https.html
    All methods are unsupported: FAIL[linux32-debug]
    If payment method identifier are supported, resolve promise with true.: FAIL[linux32-debug]
    If request.[[state]] is "created", then return a promise that resolves to true for known method.: FAIL[linux32-debug]
    Mix of supported and unsupported methods, at least one method is supported.: FAIL[linux32-debug]

Tests that are disabled for instability:
/payment-request/rejects_if_not_active.https.html
/pointerevents/pointerevent_setpointercapture_inactive_button_mouse.html
/speech-api/SpeechSynthesis-pause-resume.tentative.html
/speech-api/SpeechSynthesis-speak-ownership.html
/speech-api/SpeechSynthesis-speak-twice.html

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/18139e69e3c5
[wpt PR 15413] - Simplify test_driver_internal to not use prototype + Object.create, a=testonly

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26d55c6031ff
[wpt PR 15413] - Simplify test_driver_internal to not use prototype + Object.create, a=testonly

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/26d55c6031ff