Closed
Bug 1528286
Opened 5 years ago
Closed 5 years ago
Remove bogus comment about relocations in generated code
Categories
(Core :: DOM: Bindings (WebIDL), enhancement)
Core
DOM: Bindings (WebIDL)
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(2 files)
|
5.59 KB,
patch
|
Details | Diff | Splinter Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
It's talking about a relocation for a string constant, but those don't incur a relocation.
I tried switching to computing the string at runtime, and that does not decrease any of the data sizes for the binary, while it does increase the codesize some. So probably not worth it.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
There are no relocations needed for string constants.
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/23f41d068c94 Remove bogus comment. r=froydnj
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•