Closed
Bug 1528349
Opened 6 years ago
Closed 6 years ago
Move SetTimeout/Interval firing-order assertion to DIAGNOSTIC_ASSERT
Categories
(Core :: DOM: Core & HTML, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: jesup, Assigned: jesup)
References
Details
Attachments
(1 file)
|
5.12 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
We have indications that rarely this assertion can fail, but can't get a reproducible case. Moving the assertion to MOZ_DIAGNOSTIC_ASSERT to try to make sure we catch it, and that it's not breaking sites anywhere.
|
Assignee | |
Comment 1•6 years ago
|
||
If when this lands we get any significant hitrate on it, I'll likely back the patch out until we resolve the problem. I don't expect that, but it's possible. DIAGNOSTIC_ASSERT to ensure we can't accidentally ship this.
Attachment #9044337 -
Flags: review?(bugs)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9044337 [details] [diff] [review]
Move a DOM timeout spec-compliance ASSERT to DIAGNOSTIC_ASSERT
(and r+ if you need to back this out quickly to keep Nightlies working, though need to then also figure out what is wrong with timers)
Attachment #9044337 -
Flags: review?(bugs) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8058a73d119
Move a DOM timeout spec-compliance ASSERT to DIAGNOSTIC_ASSERT r=smaug
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Backout by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb69f933e572
Backed out changeset f8058a73d119 r=smaug
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•