Closed Bug 1528387 Opened 9 months ago Closed 9 months ago

Name of actor for JSWindowActor::SendAsyncMessage should be implicit

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Fission Milestone M1
Tracking Status
firefox67 --- fixed

People

(Reporter: Nika, Assigned: Nika)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Whiteboard: [2/20] patch r+, ready to land
Blocks: 1467212
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33dd29846b7b
Make actor name implicit to JSWindowActor::SendAsyncMessage, r=jdai
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c4c6581b5ecd
Added newline at the end of the files because of eslint failure. r=eslint-fix

It should also change JSWindowActor::SendAsyncMessage in test_JSWindowActor.xul[1]. Will update a patch to address them.

[1] https://searchfox.org/mozilla-central/rev/4587d146681b16ff9878a6fdcba53b04f76abe1d/dom/ipc/tests/test_JSWindowActor.xul#73

Flags: needinfo?(nika)
Status: NEW → ASSIGNED
Whiteboard: [2/20] patch r+, ready to land → [2/21] patch bounced, working on the fix
Attached patch fix.patchSplinter Review

Fix back out and mozlint.

Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81df30b5a3a1
Make actor name implicit to JSWindowActor::SendAsyncMessage, r=jdai
Whiteboard: [2/21] patch bounced, working on the fix → [2/22] patch pushed
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Whiteboard: [2/22] patch pushed
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.