1528453 - One-click search engine list in about:preferences has overlapping elements

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Kestrel]

Attachment: search-engine-overlap.png

The hboxes for oneClickSearchProvidersGroup are overlapping the engineList tree.

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=7436c0f5b8b1583d20d5ea2d1d9d3b2c665bdf33&tochange=795f2e303548acd4d239e681331daa224cdab497

Regressed by Bug 1527410.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Thanks for reporting this Kestrel :)

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1528453 - Don't use min-height: 0 for xul trees.

In the regressing bug I accidentally removed a special-case for
min-{height/width}: 0 that treated it as auto for XUL trees:

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf8e35be76d8#l34.94

I can put it back if you think it's better, but these two lines of code were
here before min-width: auto even existed (min-width: 0 used to be the default).

I think this is better than changing the platform back to special-case
min-width: 0, and I don't see many other problematic uses of min-height /
min-width: 0, so let's try this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47bcf8f29a21
Don't use min-height: 0 for xul trees. r=bgrins

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/47bcf8f29a21

Comment 5

[Alexandru Trif, Desktop QA [:atrif]]

Confirmed the issue with 67.0a1 (20190215184035) on Windows 10 x64, Ubuntu 18.04 x64, macOS 10.13.6.
Fix verified with 67.0a1 (20190306095759), Windows 10 x64, Ubuntu 18.04 x64, macOS 10.13.6.