Closed Bug 1528570 Opened 1 year ago Closed 1 year ago

Missing error handling when calling NS_tremove() in UpdateThreadFunc()

Categories

(Toolkit :: Application Update, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 --- unaffected
firefox67 --- fixed

People

(Reporter: ehsan, Assigned: robert.strong.bugs)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

Coverity points to the fact that the return value from the remove() function being called here: https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/updater/updater.cpp#2492-2493 isn't being checked, unlike several other places in this file.

Ehsan, where are you getting the coverity scan data? I have a coverity account that I use for the Firefox scan and the last scan was two months ago.

Flags: needinfo?(ehsan)

(In reply to Robert Strong (Robert he/him) [:rstrong] (use needinfo to contact me) from comment #1)

Ehsan, where are you getting the coverity scan data? I have a coverity account that I use for the Firefox scan and the last scan was two months ago.

We have a private instance setup right now where you can look at all of the issues it finds including this one, I believe Andi can get you an account if you need one.

Flags: needinfo?(ehsan) → needinfo?(bpostelnicu)

I'd appreciate an account. Thanks!

Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bad5b253a10c
Add back test only return value of NS_tremove check. r=mhowell

(In reply to Robert Strong (Robert he/him) [:rstrong] (use needinfo to contact me) from comment #4)

I'd appreciate an account. Thanks!

Hello Robert, I've sent you an invitation. If you need anything else please feel free to poke me on irc.

Flags: needinfo?(bpostelnicu)
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → robert.strong.bugs
You need to log in before you can comment on or make changes to this bug.