1528570 - Missing error handling when calling NS_tremove() in UpdateThreadFunc()

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[(no longer active)]

Coverity points to the fact that the return value from the remove() function being called here: https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/updater/updater.cpp#2492-2493 isn't being checked, unlike several other places in this file.

Comment 1

[Robert Strong (they/them - no direct email)]

Ehsan, where are you getting the coverity scan data? I have a coverity account that I use for the Firefox scan and the last scan was two months ago.

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: Bug 1528570 - Add back test only return value of NS_tremove check. r?mhowell

Comment 3

[(no longer active)]

(In reply to Robert Strong (Robert he/him) [:rstrong] (use needinfo to contact me) from comment #1)

Ehsan, where are you getting the coverity scan data? I have a coverity account that I use for the Firefox scan and the last scan was two months ago.

We have a private instance setup right now where you can look at all of the issues it finds including this one, I believe Andi can get you an account if you need one.

Comment 4

[Robert Strong (they/them - no direct email)]

I'd appreciate an account. Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bad5b253a10c
Add back test only return value of NS_tremove check. r=mhowell

Comment 6

[Andi [:andi]]

(In reply to Robert Strong (Robert he/him) [:rstrong] (use needinfo to contact me) from comment #4)

I'd appreciate an account. Thanks!

Hello Robert, I've sent you an invitation. If you need anything else please feel free to poke me on irc.

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bad5b253a10c