Closed Bug 1528573 Opened 9 months ago Closed 8 months ago

[RTL] The sloth SVG is overlapping the header in about:rights

Categories

(Toolkit :: General, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla68
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 + fixed
firefox68 --- verified

People

(Reporter: itiel_yn8, Assigned: chengy12)

References

(Regression)

Details

(Keywords: regression, rtl)

Attachments

(2 files)

Attached image Screenshot

The sloth SVG should be placed on the left side of the header.
See attached for how this currently looks in RTL.

Duplicate of this bug: 1539776

Itiel, do you know if this is a new regression introduced in 67? Are you able to reproduce this on the Firefox release version?

Flags: needinfo?(itiel_yn8)

(In reply to Neha Kochar [:neha] from comment #2)

Itiel, do you know if this is a new regression introduced in 67? Are you able to reproduce this on the Firefox release version?

Regression from bug 1519923.

Flags: needinfo?(itiel_yn8)

chengy12, could you please look into this regression from bug 1519923?

Gijs, your thoughts on this?

Flags: needinfo?(gijskruitbosch+bugs)
Flags: needinfo?(chengy12)
Regressed by: 1519923

https://searchfox.org/mozilla-central/rev/44a212460990ffffecf50a8e972d3cbde2e7216b/toolkit/themes/shared/aboutRights.css#13-15

needs fixing now we no longer set the direction on the <body>. It should use :-moz-locale-dir(rtl) to accomplish the same thing.

Flags: needinfo?(gijskruitbosch+bugs)
Assignee: nobody → chengy12
No longer blocks: 1519923
Has Regression Range: --- → yes
Has STR: --- → yes

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See How Do You Triage for more information

Priority: P3 → P1
Flags: needinfo?(chengy12)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0cf838d61cdd
[RTL] The sloth SVG is overlapping the header in about:rights, r=Gijs
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Fixed on latest Nightly. I'm guessing this needs an uplift?

Flags: needinfo?(gijskruitbosch+bugs)
Status: RESOLVED → VERIFIED

Comment on attachment 9055713 [details]
Bug 1528573 - [RTL] The sloth SVG is overlapping the header in about:rights, r?Gijs

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1519923
  • User impact if declined: clashing background image and text in RTL on about:rights
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: n/a
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Single-line CSS only RTL-only fix to make the sloth in about:rights appear on the right... I mean, correct (left) side on RTL. :-)
  • String changes made/needed: nope
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #9055713 - Flags: approval-mozilla-beta?

Comment on attachment 9055713 [details]
Bug 1528573 - [RTL] The sloth SVG is overlapping the header in about:rights, r?Gijs

Trivial CSS patch, verified on Nightly, uplift approved for 67 beta 9, thanks!

Attachment #9055713 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.