1528594 - Developer tools debugger context menu shortcut missing plus char

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[David Balažic]

Attachment: ffplusmissing.png

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

F12
Debugger
show/open a JS source
right click on a line number

Actual results:

context menu appears, the shown keyboard shortcuts are missing the plus character:

Add breakpoint CtrlB
Add conditional breakpoint CtrlShiftB

Expected results:

context menu appears, the shown keyboard shortcuts are like this:

Add breakpoint Ctrl+B
Add conditional breakpoint Ctrl+Shift+B

Comment 1

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0
20190216214513

:jlast please have a look at this. It's no longer reproducible in the latest Nightly. The fix range points to bug 1525492 but at the same time, changes were backed out and the report is still open.

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=76e0d806619a5954ac5341f7330fbde3be3d5f4c&tochange=85c562f9b5fd1d8aa5c4b9d6e532b96cb6a0c798

Comment 2

[Jason Laster [:jlast]]

Thanks for following up. I don't see the + in Nightly either.

David, would you be able to follow up? I think this work is relevant - https://github.com/firefox-devtools/debugger/pull/7893/files

Comment 3

[Gingerbread Man]

Attachment: Screenshot Nightly 20190222081112.png

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0
20190222081112

(In reply to Jason Laster [:jlast] from comment #2)

I don't see the + in Nightly either.

Still works for me.

Comment 4

[David Walsh :davidwalsh]

I'm still looking into this. The pull request cited only changes items for Mac, and the screenshots provided are for Windows. Additionally, there's no change in display with code prior to that PR, so I think we can rule it out.

Comment 5

[David Walsh :davidwalsh]

:honza Do you know how these menu items are generated on Windows, which is where the "+" appears to be missing?

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

NI myself

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: image.png

I can't reproduce the issue on Win10
(see the attached screenshot, it looks just fine)

Honza

Comment 8

[David Walsh :davidwalsh]

I can't reproduce either.