Remove telemetry probes for HTMLEditors which have shown Gecko build-in editing UIs and if they are operated
Categories
(Core :: DOM: Editor, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
According to the telemetry dashboard, there are no users of the grip to move absolute position at least beta and dev edition users. On the other hand, over one thousand users are perhaps actually using the inline table editor and the object resizer. So, we might be possible to remove only the former, but perhaps, the latter UIs are used by a few apps which is used only by them (I guess an intranet application in an organization).
Anyway, I think that we don't need to have the telemetry probes anymore since such small numbers won't become 0 in short term. Actually, the UIs were disabled by default in 64 cycle, but beta 65 and dev edition 65 users kept using those UIs. So, the application must be maintained to making the UIs enabled.
|
||
Comment 1•5 years ago
|
||
So I guess there is no way to find out what the reason for using them is? If they continue to be used, some JavaScript developer must have investigated how to reenable the table controls. Wherever that was documented would maybe be a good idea some time in the future to ask the developers to contact us and present their usecase in order to prevent the feature from being removed entirely.
If we are talking about up to 1000 users, they may all be using one and the same application/site, so the day that site updates their editor the number of users may drop to 0 within minutes. We don't know when that will happen, so I agree that it makes little sense to keep telemetry probes running all the time, but if it's simple enough to reenable them, I would suggest to try again say every 5 or 10 versions to see if there are still users around.
|
Assignee | |
Comment 2•5 years ago
|
||
I guess there is no way to find out what the reason for using them is?
Yes.
If we are talking about up to 1000 users, they may all be using one and the same application/site, so the day that site updates their editor the number of users may drop to 0 within minutes. We don't know when that will happen, so I agree that it makes little sense to keep telemetry probes running all the time, but if it's simple enough to reenable them, I would suggest to try again say every 5 or 10 versions to see if there are still users around.
Unfortunately, we don't have the way to collect the data only on specific cycle. One of the difficult point to remove the features completely is, we still need to have them at least on Thunderbird. So, even if we'd remove the UIs, we'd need to port them to Thunderbird, and the cost is not so cheap. Therefore, even if there is only one organization using the features, keeping the features with disabling them by default makes sense for now. (If we'd reimplement them with JS, we could remove them from C++ code. Then, we could port them without any additional cost though.)
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
Those probes are now expired and we got enough data:
- Almost no user uses the grip to move absolute positioned element
- There were over one thousand users using the inline table editor and the object resizers.
- Such users keep using even after we disabled the UIs by default.
Perhaps, such small number of users keep using the UIs, i.e., I guess the
number won't become smaller in short term. Therefore, this patch removes the
telemetry probes and members of HTMLEditor which are necessary to call
Telemetry API.
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/d3cacfd1b84e Remove telemetry probes for HTMLEditors which have shown Gecko build-in editing UIs and if they are operated r=m_kato,Ehsan
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•