[wpt-sync] Sync PR 15388 - SignedExchange: Close response body data pipe on integrity error
Categories
(Testing :: web-platform-tests, enhancement, P4)
Tracking
(firefox67 fixed)
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 15388 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/15388
Details from upstream follow.
Kunihiko Sakamoto <ksakamoto@chromium.org> wrote:
SignedExchange: Close response body data pipe on integrity error
This fixes a bug where data pipe for response body was not closed when
Signed Exchange has payload integrity error.SourceStreamToDataPipe::OnComplete() attempts to close the pipe by
resetting |pending_write_|. But if |source_| is a FilterSourceStream, it
still retains a reference to |pending_write_|. We should explicitly call
|pending_write_->Complete(0)| to free the pipe on error cases too.Bug: 931955
Change-Id: I63b2470dbb92aa57016c5c71222bcdabe889fd34
Reviewed-on: https://chromium-review.googlesource.com/c/1470355
Reviewed-by: Kinuko Yasuda \<kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto \<ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632118}
|
Assignee | |
Comment 1•2 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2d5413723c06276bab7d8dba62bbe3d94e39372
|
|
Assignee | |
Comment 2•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=59269b062bacc57deaa587e969b4c06ab2b324e1
|
|
Assignee | |
Comment 3•2 years ago
|
||
Ran 2 tests and 2 subtests
OK : 2
PASS : 1
FAIL : 1
New tests that have failures or other problems:
/signed-exchange/sxg-prefetch-merkle-integrity-error.tentative.html
Prefetching SignedHTTPExchange with payload integrity error should fail: FAIL
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/8b3668ee0579 [wpt PR 15388] - SignedExchange: Close response body data pipe on integrity error, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/b571112619c2 [wpt PR 15388] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/1c69ba77f5c9 [wpt PR 15388] - SignedExchange: Close response body data pipe on integrity error, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/c8eeaabc6e78 [wpt PR 15388] - Update wpt metadata, a=testonly
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1c69ba77f5c9
https://hg.mozilla.org/mozilla-central/rev/c8eeaabc6e78
Description
•