Closed
Bug 1528758
Opened 5 years ago
Closed 5 years ago
Redundant null-checks before calling hb_*_destroy APIs
Categories
(Core :: Graphics: Text, enhancement)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
Details
Attachments
(1 file)
In a bunch of places, we null-check a member variable (e.g. in gfxHarfBuzzShaper) before calling hb_blob_destroy or other hb_*_destroy functions.
This is redundant, as the hb_*_destroy functions start by checking their argument and return safely if null. So we can tidy up gecko code by removing these checks.
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b3f5c1b6b44d No need for a null-check before calling hb_*_destroy functions, as they do it internally. r=jrmuizel
Comment 3•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Updated•5 years ago
|
Assignee: nobody → jfkthame
You need to log in
before you can comment on or make changes to this bug.
Description
•