1528758 - Redundant null-checks before calling hb_*_destroy APIs

Status: RESOLVED FIXED

(Core :: Graphics: Text, enhancement)

Description

[Jonathan Kew [:jfkthame]]

In a bunch of places, we null-check a member variable (e.g. in gfxHarfBuzzShaper) before calling hb_blob_destroy or other hb_*_destroy functions.

This is redundant, as the hb_*_destroy functions start by checking their argument and return safely if null. So we can tidy up gecko code by removing these checks.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1528758 - No need for a null-check before calling hb_*_destroy functions, as they do it internally. r?jrmuizel

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3f5c1b6b44d
No need for a null-check before calling hb_*_destroy functions, as they do it internally. r=jrmuizel

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b3f5c1b6b44d