Closed Bug 1528770 Opened 5 years ago Closed 5 years ago

Support release_or_beta key in wpt-in-jstests

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review

mozinfo grabs this from the objdir, but only if you're running under mach. Unfortunately that isn't common practice for SpiderMonkey hackers, so this explicitly defines the key in jstests.

(I'm not sure that pulling in everything from mozinfo automatically is the greatest approach, but that's a subject for another time.)

Attachment #9044673 - Flags: review?(james)
Comment on attachment 9044673 [details] [diff] [review]
Patch

Review of attachment 9044673 [details] [diff] [review]:
-----------------------------------------------------------------

I wonder if we should put in everything in getBuildConfiguration.

I agree that having an unrestricted set of properties here is difficult for jstests, but otoh we have found occasion to make use of a surprising number of them and I'm not sure that people would notice they were breaking jstests if they had to update a list, at least without a specific comment. But maybe that would still be better.
Attachment #9044673 - Flags: review?(james) → review+
Pushed by Ms2ger@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a7c9fc1c794
Support release_or_beta key in wpt-in-jstests; r=jgraham
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: