Closed Bug 1528803 Opened 8 months ago Closed 8 months ago

Handle JSOP_BIGINT in ExpressionDecompiler::decompilePC

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: anba, Assigned: wingo)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

dis("0n") prints

loc     op
-----   --
main:
00000:  bigint 0                        # <unknown>
00005:  setrval                         # 
00006:  retrval                         #

which means JSOP_BIGINT isn't handled in ExpressionDecompiler::decompilePC.

See https://searchfox.org/mozilla-central/rev/05d4b6962a571585bd679d2bbb0df0a5fb4e4eff/js/src/vm/BytecodeUtil.cpp#2105

Keywords: checkin-needed

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/95e3e6f91e6e
Add decompile support for new instructions r=jwalden

Keywords: checkin-needed
Flags: needinfo?(wingo)
Keywords: checkin-needed
Assignee: nobody → wingo

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/698edbbeb0c5
Add decompile support for new instructions r=jwalden

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.