1528814 - Serialize Loadinfo for PExternalHelperApp

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Description

[Christoph Kerschbaumer [:ckerschb]]

Within Bug 1528677 we want to eliminate all nullchecks whenever we query the loadinfo from the channel. While doing so I encountered that we hit null pointer exceptions within ExternalHelperAppParent. Hence it makes sense that we serialize the loadinfo.

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

One of the failing tests was e.g.

dom/security/test/general/browser_test_data_download.js

with the following stacktrace:

0:47.12 GECKO(20307) #01: nsIChannel::LoadInfo() (/home/ckerschb/source/mc-dbg/dist/include/nsIChannel.h:129)
0:47.18 GECKO(20307) #02: NS_GetOriginAttributes(nsIChannel*, mozilla::OriginAttributes&) (/home/ckerschb/source/mc/netwerk/base/nsNetUtil.cpp:1710)
0:47.18 GECKO(20307) #03: NS_UsePrivateBrowsing(nsIChannel*) (/home/ckerschb/source/mc/netwerk/base/nsNetUtil.cpp:1694)
0:47.53 GECKO(20307) #04: nsExternalAppHandler::RetargetLoadNotifications(nsIRequest*) (/home/ckerschb/source/mc/uriloader/exthandler/nsExternalHelperAppService.cpp:1287)
0:47.54 GECKO(20307) #05: nsExternalAppHandler::OnStartRequest(nsIRequest*, nsISupports*) (/home/ckerschb/source/mc/uriloader/exthandler/nsExternalHelperAppService.cpp:1550)
0:47.54 GECKO(20307) #06: mozilla::dom::ExternalHelperAppParent::RecvOnStartRequest(nsTString<char> const&, mozilla::dom::PBrowserParent*) (/home/ckerschb/source/mc/uriloader/exthandler/ExternalHelperAppParent.cpp:137)
0:47.54 GECKO(20307) #07: mozilla::dom::PExternalHelperAppParent::OnMessageReceived(IPC::Message const&) (/home/ckerschb/source/mc-dbg/ipc/ipdl/PExternalHelperAppParent.cpp:145)
0:47.72 GECKO(20307) #08: mozilla::dom::PContentParent::OnMessageReceived(IPC::Message const&) (/home/ckerschb/source/mc-dbg/ipc/ipdl/PContentParent.cpp:3827)
0:47.75 GECKO(20307) #09: mozilla::ipc::MessageChannel::DispatchAsyncMessage(IPC::Message const&) (/home/ckerschb/source/mc/ipc/glue/MessageChannel.cpp:2150)
0:51.19 GECKO(20307) #10: mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) (Unified_cpp_ipc_glue1.cpp:?)

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Summary: Bug 1528814: Serialize Loadinfo for PExternalHelperApp. r=mayhemer

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5bafd3c816e
Serialize Loadinfo for PExternalHelperApp. r=mayhemer

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/d5bafd3c816e