Rename CSSPseudoElement.parentElement to CSSPseudoElement.element
Categories
(Core :: DOM: Animation, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: birtles, Assigned: birtles)
Details
Attachments
(2 files)
We added CSSPseudoElement.parentElement but after discussion the CSSWG decided to call it CSSPseudoElement.element. We should update our implementation we can also align WPT for this.
Spec issue: https://github.com/w3c/csswg-drafts/issues/2816
Spec change: https://github.com/w3c/csswg-drafts/commit/2dbf1e44a6f952ac7c626c8baba5f66900d32c89
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
As per CSSWG resolution:
https://github.com/w3c/csswg-drafts/issues/2816#issuecomment-454869173
And corresponding spec change:
https://github.com/w3c/csswg-drafts/commit/2dbf1e44a6f952ac7c626c8baba5f66900d32c89
|
|
Assignee | |
Comment 3•5 years ago
|
||
It's possible that CSSPseudoElement will grow a 'ownerDocument' member in future
so instead we should test for '.element'. We could also test for '.type' but it
seems more likely that Element will grow a 'type' member than an 'element'
member.
Ideally we should really test if the target is an instanceof CSSPseudoElement
but unfortunately the window() getter it itself defined in terms of the node()
getter (which calls isPseudoElement) so we'd end up with unbounded recursion
unless we restructure these getters.
Depends on D20427
Pushed by bbirtles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f35e52301a45 Rename CSSPseudoElement.parentElement to CSSPseudoElement.element; r=bzbarsky https://hg.mozilla.org/integration/autoland/rev/417bde7df0b6 Make isPseudoElement test for .element instead of .ownerDocument; r=daisuke
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f35e52301a45
https://hg.mozilla.org/mozilla-central/rev/417bde7df0b6
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15544 for changes under testing/web-platform/tests
Upstream PR merged
Description
•