1528900 - Nightly tasks shouldn't depend on sccache

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Mike Hommey [:glandium]]

They don't use it, which is what's expected of them, but it's a footgun that they depend on it when they're not supposed to use it.

Incidentally, having it enabled triggers this piece of code on nightlies on Windows:

https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/taskcluster/taskgraph/transforms/job/mozharness.py#343

which makes Windows builds more reproducible, but that's sheer luck. L10N builds don't benefit from that luck, and are not reproducible as a consequence. Bug 1528892 is set to improve this.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1528900 - Remove sccache dependencies from nightly builds.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1528900 - Actively prevent nightly tasks from depending on sccache.

Depends on D20299

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/926507b65050
Remove sccache dependencies from nightly builds. r=dustin
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a74c17e7363
Actively prevent nightly tasks from depending on sccache. r=dustin

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/926507b65050
https://hg.mozilla.org/mozilla-central/rev/2a74c17e7363

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/10827c7f9429
Port bug 1528900 - Remove sccache dependencies from nightly builds; rs=bustage-fix

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/722b950381ae
Port bug 1528900 - Followup: Only disable sccache on nightly builds. rs=bustage-fix

Comment 7

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #0)

They don't use it, which is what's expected of them, but it's a footgun that they depend on it when they're not supposed to use it.

Incidentally, having it enabled triggers this piece of code on nightlies on Windows:

https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/taskcluster/taskgraph/transforms/job/mozharness.py#343

which makes Windows builds more reproducible, but that's sheer luck. L10N builds don't benefit from that luck, and are not reproducible as a consequence. Bug 1528892 is set to improve this.

Fun fact, that piece of code also breaks omni.ja optimizations, cf bug 1529894 comment 5, so incidentally, this bug fixed that on nightlies (but not builds using sccache)