1528907 - Chat not working: TypeError: this.conv.addObserver is not a function

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Richard Marti (:Paenglab)]

When connecting to IRC I get this error:

TypeError: this.conv.addObserver is not a function imconv.xml:73:19
build chrome://messenger/content/chat/imconv.xml:73
addContact chrome://messenger/content/chat/imgroup.xml:78
_addConversation chrome://messenger/content/chat/chat-messenger.js:283
observe chrome://messenger/content/chat/chat-messenger.js:998
UIConversation file:///Z:/Mozilla/TB/dist/bin/components/imConversations.js:104
addConversation file:///Z:/Mozilla/TB/dist/bin/components/imConversations.js:611
_init resource:///modules/jsProtoHelper.jsm:461
ircConversation file:///Z:/Mozilla/TB/dist/bin/components/irc.js:658
getConversation file:///Z:/Mozilla/TB/dist/bin/components/irc.js:1744
writeMessage resource:///modules/ircBase.jsm:109
serverMessage resource:///modules/ircBase.jsm:120
NOTICE resource:///modules/ircBase.jsm:292
_handleMessage resource:///modules/ircHandlers.jsm:130
handleMessage resource:///modules/ircHandlers.jsm:144
onDataReceived file:///Z:/Mozilla/TB/dist/bin/components/irc.js:748
_handleQueue resource:///modules/socket.jsm:485
_handleQueue self-hosted:974

and

TypeError: aSubject.addObserver is not a function index_im.jsm:466:16
TypeError: aSubject.conversation is undefined imConversations.js:442:9

Comment 1

[Florian Quèze [:florian]]

I tried to reproduce this bug can't even go this far because in a current trunk build I can't create an IRC account.

getProtoUserSplits and getProtoOptions at
https://searchfox.org/comm-central/rev/ba88007f5789c0011a37b1952c57f4a9bf67743b/mail/components/im/content/imAccountWizard.js#370-375 return broken objects that have no interface. Doing a manual QueryInterface to the expected interface works, so this points to the nsIClassInfo implementation used at https://searchfox.org/comm-central/rev/ba88007f5789c0011a37b1952c57f4a9bf67743b/chat/modules/jsProtoHelper.jsm#778 being broken or being by passed by a wrapper.

I suspect the stack you got is due to the ClassInfo at https://searchfox.org/comm-central/rev/ba88007f5789c0011a37b1952c57f4a9bf67743b/chat/components/src/imConversations.js#108 not working, ie. I think we are seeing different manifestations of the same bug.

Comment 2

[Florian Quèze [:florian]]

Attachment: Bug 1528907 - Fix imXPCOMUtils' ClassInfo implementation to follow the changes from bug 1526382, r=Fallen.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/433ea630bdb8
Fix imXPCOMUtils' ClassInfo implementation to follow the changes from bug 1526382, r=Fallen.

Comment 4

[Patrick Cloke [:clokep]]

Hey Florian, I think there are some instances that don't use ClassInfo, do those need to be fixed manually? https://searchfox.org/comm-central/source/chat/components/src/imContacts.js

There's a bunch of instances of getInterfaces in there.

Comment 5

[Florian Quèze [:florian]]

This needs fixing, yes. Let's do it in a follow-up though.

Comment 6

[Patrick Cloke [:clokep]]

Filed bug 1529287.