Closed Bug 1528961 Opened 5 years ago Closed 5 years ago

Intermittent LeakSanitizer | leak at operator=, WeakPtr, emplace, mozilla::ContentPrincipal::AddonPolicy, mozilla::dom::Document::InitCSP, mozilla::dom::Document::StartDocumentLoad, nsHTMLDocument::StartDocumentLoad

Categories

(Core :: DOM: Core & HTML, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- fixed
firefox65 --- unaffected
firefox66 --- fixed
firefox67 --- unaffected
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mccr8)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [stockwell unknown][land on beta and esr68])

Attachments

(3 files, 1 obsolete file)

#[markdown(off)]
Filed by: btara [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=229176975&repo=mozilla-beta

https://queue.taskcluster.net/v1/task/cnOKLpJjQh2jfbozYl2pVw/runs/0/artifacts/public/logs/live_backing.log

[task 2019-02-19T12:00:04.510Z] 12:00:04 INFO - TEST-START | /websockets/referrer.any.worker.html
[task 2019-02-19T12:00:05.568Z] 12:00:05 INFO - Closing window 360777252865
[task 2019-02-19T12:00:05.631Z] 12:00:05 INFO - .
[task 2019-02-19T12:00:05.631Z] 12:00:05 INFO - TEST-OK | /websockets/referrer.any.worker.html | took 1125ms
[task 2019-02-19T12:00:08.733Z] 12:00:08 INFO - Browser exited with return code 0
[task 2019-02-19T12:00:08.734Z] 12:00:08 INFO - PROCESS LEAKS None
[task 2019-02-19T12:00:08.734Z] 12:00:08 INFO - ERROR | LeakSanitizer | SUMMARY: AddressSanitizer: 1044 byte(s) leaked in 7 allocation(s).
[task 2019-02-19T12:00:08.734Z] 12:00:08 INFO - LeakSanitizer | To show the addresses of leaked objects add report_objects=1 to LSAN_OPTIONS
[task 2019-02-19T12:00:08.735Z] 12:00:08 INFO - This can be done in testing/mozbase/mozrunner/mozrunner/utils.py
[task 2019-02-19T12:00:08.735Z] 12:00:08 INFO - Allowed depth was 7
[task 2019-02-19T12:00:08.736Z] 12:00:08 INFO - TEST-FAIL | LeakSanitizer | leak at NewPage, Push, mozilla::EventQueue::PutEvent, mozilla::ThrottledEventQueue::Inner::Dispatch, Dispatch, EnsureExecutor, mozilla::ThrottledEventQueue::Inner::Dispatch
[task 2019-02-19T12:00:08.737Z] 12:00:08 INFO - INFO | LeakSanitizer | Frame NewPage matched a expected leak
[task 2019-02-19T12:00:08.739Z] 12:00:08 INFO - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at operator=, WeakPtr, emplace, mozilla::ContentPrincipal::AddonPolicy, mozilla::dom::Document::InitCSP, mozilla::dom::Document::StartDocumentLoad, nsHTMLDocument::StartDocumentLoad
[task 2019-02-19T12:00:08.741Z] 12:00:08 INFO - TEST-FAIL | LeakSanitizer | leak at Create, mozilla::ThrottledEventQueue::Create, mozilla::dom::WorkerPrivate::WorkerPrivate, mozilla::dom::WorkerPrivate::Constructor, mozilla::dom::Worker::Constructor, mozilla::dom::Worker_Binding::_constructor, CallJSNative
[task 2019-02-19T12:00:08.743Z] 12:00:08 INFO - INFO | LeakSanitizer | Frame Create matched a expected leak
[task 2019-02-19T12:00:08.744Z] 12:00:08 INFO - TEST-FAIL | LeakSanitizer | leak at Alloc, nsTSubstring, nsTSubstring, nsTSubstring, nsTString, InitRunnable, mozilla::dom::WebSocket::ConstructorCommon
[task 2019-02-19T12:00:08.746Z] 12:00:08 INFO - INFO | LeakSanitizer | Frame Alloc matched a expected leak
[task 2019-02-19T12:00:08.747Z] 12:00:08 INFO - TEST-FAIL | LeakSanitizer | leak at NewPage, Push, mozilla::EventQueue::PutEvent, mozilla::ThrottledEventQueue::Inner::Dispatch, DispatchToMainThread, mozilla::dom::WorkerControlRunnable::DispatchInternal, Dispatch
[task 2019-02-19T12:00:08.749Z] 12:00:08 INFO - INFO | LeakSanitizer | Frame NewPage matched a expected leak
[task 2019-02-19T12:00:08.749Z] 12:00:08 INFO - TEST-FAIL | LeakSanitizer | leak at mozilla::dom::WebSocket::WebSocket, mozilla::dom::WebSocket::ConstructorCommon, mozilla::dom::WebSocket::Constructor, mozilla::dom::WebSocket_Binding::_constructor, CallJSNative, CallJSNativeConstructor, InternalConstruct
[task 2019-02-19T12:00:08.749Z] 12:00:08 INFO - INFO | LeakSanitizer | Frame mozilla::dom::WebSocket::WebSocket matched a expected leak
[task 2019-02-19T12:00:08.750Z] 12:00:08 INFO - TEST-FAIL | LeakSanitizer | leak at mozilla::net::nsStandardURL::TemplatedMutator, Init, mozilla::net::nsStandardURL::TemplatedMutator, operator, std::_Function_handler, operator, Apply
[task 2019-02-19T12:00:08.750Z] 12:00:08 INFO - INFO | LeakSanitizer | Frame mozilla::net::nsStandardURL::TemplatedMutator matched a expected leak
[task 2019-02-19T12:00:08.750Z] 12:00:08 INFO - TEST-FAIL | LeakSanitizer | leak at Alloc, nsTSubstring, nsTSubstring, mozilla::net::nsStandardURL::BuildNormalizedSpec, mozilla::net::nsStandardURL::SetSpecWithEncoding, mozilla::net::nsStandardURL::Init, Init
[task 2019-02-19T12:00:08.750Z] 12:00:08 INFO - INFO | LeakSanitizer | Frame Alloc matched a expected leak
[task 2019-02-19T12:00:08.751Z] 12:00:08 INFO - TEST-FAIL | LeakSanitizer | leak at mozilla::SchedulerGroup::CreateEventTargetFor, mozilla::SchedulerGroup::CreateEventTargets, mozilla::dom::TabGroup::TabGroup, mozilla::dom::nsIContentChild::GetConstructedEventTarget, mozilla::ipc::IToplevelProtocol::ToplevelState::GetMessageEventTarget, GetMessageEventTarget, mozilla::ipc::MessageChannel::MessageTask::Post
[task 2019-02-19T12:00:08.751Z] 12:00:08 INFO - INFO | LeakSanitizer | Frame mozilla::SchedulerGroup::CreateEventTargetFor matched a expected leak
[task 2019-02-19T12:00:08.751Z] 12:00:08 INFO - TEST-FAIL | LeakSanitizer | leak at Create, nsAtomTable::Atomize, mozilla::BasePrincipal::FinishInit, Init, mozilla::ContentPrincipal::Read, nsBinaryInputStream::ReadObject, NS_DeserializeObject
[task 2019-02-19T12:00:08.751Z] 12:00:08 INFO - INFO | LeakSanitizer | Frame Create matched a expected leak
[task 2019-02-19T12:00:08.752Z] 12:00:08 INFO - TEST-FAIL | LeakSanitizer | leak at mozilla::BasePrincipal::CreateCodebasePrincipal, mozilla::BasePrincipal::CreateCodebasePrincipal, nsScriptSecurityManager::GetChannelURIPrincipal, nsScriptSecurityManager::GetChannelResultPrincipal, mozilla::dom::Document::Reset, nsHTMLDocument::Reset, mozilla::dom::Document::StartDocumentLoad
[task 2019-02-19T12:00:08.752Z] 12:00:08 INFO - INFO | LeakSanitizer | Frame mozilla::BasePrincipal::CreateCodebasePrincipal matched a expected leak
[task 2019-02-19T12:00:08.752Z] 12:00:08 INFO - TEST-FAIL | LeakSanitizer | leak at mozilla::ThrottledEventQueue::Create, mozilla::dom::WorkerPrivate::WorkerPrivate, mozilla::dom::WorkerPrivate::Constructor, mozilla::dom::Worker::Constructor, mozilla::dom::Worker_Binding::_constructor, CallJSNative, CallJSNativeConstructor
[task 2019-02-19T12:00:08.753Z] 12:00:08 INFO - INFO | LeakSanitizer | Frame mozilla::ThrottledEventQueue::Create matched a expected leak
[task 2019-02-19T12:00:08.754Z] 12:00:08 INFO - Closing logging queue

Hi Kris,
Since you added "mAddon.emplace(EPS().GetByURL(mCodebase.get()));" in ContentPrincipal::AddonPolicy(), could you please take a look at this? Thanks!

Flags: needinfo?(kmaglione+bmo)

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #3)

Hi Kris,
Since you added "mAddon.emplace(EPS().GetByURL(mCodebase.get()));" in ContentPrincipal::AddonPolicy(), could you please take a look at this? Thanks!

That's a weak pointer, so I'm fairly certain it's not relevant.

Flags: needinfo?(kmaglione+bmo)

This is beta-only, and there's a ton of other stuff leaking, so I expect this is something falling between the cracks of whitelisting. I can paper it over.

Assignee: nobody → continuation

Please land this on beta. It is a test-only change, so no approval is required.

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Priority: -- → P3
Component: DOM → DOM: Core & HTML

This happened again because we merged m-c to beta. I don't know why the whitelist keeps failing, but this time I'll land it on m-c, then beta, so it won't break again next time.

This continues to fail on release trees and try. Entire history: https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2019-06-10&endday=2019-10-08&tree=all&bug=1528961

Andrew are there any updates here?

Flags: needinfo?(continuation)
Attachment #9099984 - Attachment is obsolete: true
Attachment #9048251 - Attachment description: Bug 1528961 - Ignore more leaks in WPT websockets on beta. → Bug 1528961 - Whitelist AddonPolicy leak in web sockets wpt tests.
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4095064f5e06
Whitelist AddonPolicy leak in web sockets wpt tests. r=jgraham
Same patch I just landed, rebased for beta.
Attachment #9099990 - Flags: review+

I just rebased the patch and landed it on autoland, so hopefully this will stop happening in the future.

I also rebased the patch for beta and esr68, so feel free to land those patches on those branches as desired.

Flags: needinfo?(continuation)
Keywords: checkin-needed
Whiteboard: [stockwell unknown] → [stockwell unknown][land on beta and esr68]

(These patches are test only, so I think they don't need approval for uplift.)

Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: