Permission Prompts are missing "Learn More" URLs
Categories
(Firefox :: Site Identity, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox65 | --- | unaffected |
| firefox66 | --- | unaffected |
| firefox67 | --- | verified |
People
(Reporter: johannh, Assigned: bgrins)
References
Details
(Keywords: regression)
Attachments
(1 file)
STR:
Go to https://permission.site and show the geolocation prompt. It should have a "Learn More" URL, but it doesn't anymore.
This was regressed by bug 1487065.
Brian, can you please look into it? :)
Thanks!
|
||
Comment 1•5 years ago
|
||
Hmm… I was pretty sure we had test coverage for some learn more links.
|
Reporter | |
Comment 2•5 years ago
|
||
(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)
Hmm… I was pretty sure we had test coverage for some learn more links.
Yeah, I was under the same impression, but I couldn't find any on a quick glance.
|
Assignee | |
Comment 3•5 years ago
|
||
I guess the [href] isn't being set properly, since it seems that's what controls if it's visible or not (https://searchfox.org/mozilla-central/rev/93905b660fc99a5d52b683690dd26471daca08c8/toolkit/themes/shared/popupnotification.inc.css#31). Will take a look.
|
|
Assignee | |
Comment 4•5 years ago
|
||
Actually, the [href] is being set. The textContent (set to &learnMore;) is getting dropped somehow: https://searchfox.org/mozilla-central/rev/93905b660fc99a5d52b683690dd26471daca08c8/toolkit/content/widgets/popupnotification.js#75.
|
|
Assignee | |
Comment 5•5 years ago
|
||
Need to figure out why this fixes it, the textContent shouldn't get dropped.
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 6•5 years ago
|
||
This was an issue with the parseXULToFragment helper, surprised this hasn't come up before. Thanks for filing.
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9af9ed6a354d Only remove whitespace-only text nodes in parseXULToFragment r=MattN
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
|
||
Comment 9•5 years ago
|
||
I have reproduced this bug with Nightly 67.0a1 (2019-02-19) on Windows 7, 64 Bit. The fix of this bug is now verified with latest Nightly!
Build ID 20190222081112
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0
|
||
Updated•5 years ago
|
Description
•