Closed
Bug 1528979
Opened 5 years ago
Closed 5 years ago
Utils.hasLocalData() should return true even if local dump is an empty list
Categories
(Firefox :: Remote Settings Client, enhancement)
Firefox
Remote Settings Client
Tracking
()
RESOLVED
FIXED
Firefox 67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: leplatrem, Assigned: leplatrem)
Details
Attachments
(1 file)
Currently, if you ship an empty dump ({"data":[]}), it will get loaded but Utils.hasLocalData() will continue to return false. Mainly because it looks for a local timestamp, and in this particular case none is saved.
It should return true, because we consider that if there is a local dump, then there is a local collection of data, even if it is empty :)
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → mathieu
|
|
Assignee | |
Comment 1•5 years ago
|
||
Fix loading of empty JSON dump
Storing an empty JSON dump should prevent .get() to initiate a sync.
|
|
Assignee | |
Comment 2•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2096e0d1ff3eb5f81184c53c0d566131ee0a44b3
Pushed by mleplatre@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1e088259e033 Fix loading of empty JSON dump in Remote Settings r=glasserc
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in
before you can comment on or make changes to this bug.
Description
•