Tell WR about how much scrollframes have scrolled
Categories
(Core :: Graphics: WebRender, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file, 1 obsolete file)
There was some discussion on IRC here: https://mozilla.logbot.info/gfx/20190218#c15982523
The gist of it is that WR can do stuff better if it knows how much all the display items got shifted by due to scrolling. It should be easy to provide WR with the scroll offset for each scrollframe, so that it can do this.
|
Assignee | |
Comment 1•5 years ago
|
||
This patch (which I haven't tried compiling) should provide WR with the gecko scroll offset for each scrollframe when that scrollframe is defined. If you subtract off the display items positions by the scroll offset of the enclosing scrollframe that should give you a normalized value that should be consistent from one DL to the next. Hopefully this is enough for you to test out any changes you want to make.
|
||
Comment 2•5 years ago
|
||
I fixed up a couple of minor compile errors, and have been experimenting with this. It seems to provide the missing information that WR needs to simplify and optimize the existing picture caching code. I think we could land this as a standalone patch, it's certainly going to be useful to WR in one way or another.
|
|
Assignee | |
Comment 3•5 years ago
|
||
Sounds good. I can clean it up and land it then.
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/59ec14e90a54 Send the gecko scroll offsets for scrollframes to WR. r=gw
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
Description
•