1529026 - move verify things to separate stage

Status: RESOLVED FIXED

(Socorro :: Antenna, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

When Antenna is starting up, it verifies various things as components are instantiated. For example, it'll HEAD the S3 bucket when the S3CrashStorage and Connection instances are instantiated.

This has a couple of problems:

1. The logs are a little weird because the configuration being logged is interrupted with other messages.

2. We're adding additional verification code and it'd be better to have this all happen at the same time as a group rather than haphazardly. It'd be easier to debug in the logs.

3. Verification should be a first-class step in starting up.

Thus, I think we should change it so that all verification should happen after things are instantiated but before the server starts accepting connections. Maybe we could use the HeartbeatManager and hooks for this?

This bug covers that work.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this to do now because I want to use it for the pubsub work.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 293: fix bug 1529026: make verification a separate step

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #293: "fix bug 1529026: make verification a separate step" in f8dd8a2.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Looks good on stage. Marking this as FIXED.