Closed Bug 1529043 Opened 6 years ago Closed 6 years ago

Fix app update tests so eslint-disable no-undef can be removed from xpcshellUtilsAUS.js

Categories

(Toolkit :: Application Update, enhancement)

Product:
Toolkit
Component:
Application Update
Version:
59 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(10 files)

Bug 1529043 - Part 1 (test only) - change waitForUpdateXMLFiles call sites to use await instead of having waitForUpdateXMLFiles call waitForUpdateXMLFilesFinished. r?mhowell
47 bytes, text/x-phabricator-request
Details | Review
Bug 1529043 - Part 2 (test only) - Change runUpdate call sites to continue after calling runUpdate instead of having runUpdate call runUpdateFinished. r?mhowell
47 bytes, text/x-phabricator-request
Details | Review
Bug 1529043 - Part 3 (test only) - Make the runHelperFileInUse, runHelperPIDPersists, and runHelperLockFile functions async and change call sites so they use await. r?mhowell
47 bytes, text/x-phabricator-request
Details | Review
Bug 1529043 - Part 4 (test only) - Make the waitForHelperExit function async and change call sites so they use await. r?mhowell
47 bytes, text/x-phabricator-request
Details | Review
Bug 1529043 - Part 5 (test only) - Make the checkPostUpdateAppLog function async and change call sites so they use await. r?mhowell
47 bytes, text/x-phabricator-request
Details | Review
Bug 1529043 - Part 6 (test only) - Make the setupUpdaterTest function async and change call sites so they use await. r?mhowell
47 bytes, text/x-phabricator-request
Details | Review
Bug 1529043 - Part 7 (test only) - Make the runUpdateUsingApp function async and change call sites so they use await. r?mhowell
47 bytes, text/x-phabricator-request
Details | Review
Bug 1529043 - Part 8 (test only) - Make the stageUpdate function async and change call sites so they use await. r?mhowell
47 bytes, text/x-phabricator-request
Details | Review
Bug 1529043 - Part 9 (test only) - Create functions for checking for updates and downloading updates that return a promise. r?mhowell
47 bytes, text/x-phabricator-request
Details | Review
Bug 1529043 - Part 10 (test only) - Change IS_SERVICE_TEST into a global var to quiet eslint undefined errors and remove eslint-disable no-undef from xpcshellUtilsAUS.js. r?mhowell
47 bytes, text/x-phabricator-request
Details | Review

This way we can more easily catch errors in the app update xpcshell test code.

Also removes several global declarations that are no longer used and moved a few global declarations to where they are used

Depends on D20800

Pushed by rstrong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/36a33f399a1c Part 1 (test only) - change waitForUpdateXMLFiles call sites to use await instead of having waitForUpdateXMLFiles call waitForUpdateXMLFilesFinished. r=mhowell https://hg.mozilla.org/integration/autoland/rev/ffe15ecad744 Part 2 (test only) - Change runUpdate call sites to continue after calling runUpdate instead of having runUpdate call runUpdateFinished. r=mhowell https://hg.mozilla.org/integration/autoland/rev/efb5610ad438 Part 3 (test only) - Make the runHelperFileInUse, runHelperPIDPersists, and runHelperLockFile functions async and change call sites so they use await. r=mhowell https://hg.mozilla.org/integration/autoland/rev/a72eb0e7bb31 Part 4 (test only) - Make the waitForHelperExit function async and change call sites so they use await. r=mhowell https://hg.mozilla.org/integration/autoland/rev/52905dcc9c15 Part 5 (test only) - Make the checkPostUpdateAppLog function async and change call sites so they use await. r=mhowell https://hg.mozilla.org/integration/autoland/rev/7cff5bc91962 Part 6 (test only) - Make the setupUpdaterTest function async and change call sites so they use await. r=mhowell https://hg.mozilla.org/integration/autoland/rev/0633e80e4acc Part 7 (test only) - Make the runUpdateUsingApp function async and change call sites so they use await. r=mhowell https://hg.mozilla.org/integration/autoland/rev/17a347c99165 Part 8 (test only) - Make the stageUpdate function async and change call sites so they use await. r=mhowell https://hg.mozilla.org/integration/autoland/rev/3314bffa0d51 Part 9 (test only) - Create functions for checking for updates and downloading updates that return a promise. r=mhowell https://hg.mozilla.org/integration/autoland/rev/68c5e68c3244 Part 10 (test only) - Change IS_SERVICE_TEST into a global var to quiet eslint undefined errors and remove eslint-disable no-undef from xpcshellUtilsAUS.js. r=mhowell
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: