Add --ion-warmup-threshold=0 to fuzz-flags.txt

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: gkw, Assigned: nbp)

Tracking

Trunk
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

4 months ago

Nicolas, do you think you can add this? --ion-warmup-threshold=0 seems to find some issues that --ion-warmup-threshold=100 does not catch.

(I'm not sure if =0 finds all of the issues that =100 also finds though, i.e. I'm not sure if the =100 set of bugs is a subset of the =0 ones. Hence I'm not sure if they are either/or or we should have both)

Flags: needinfo?(nicolas.b.pierron)
Assignee

Comment 2

4 months ago

(In reply to Gary Kwong [:gkw] [:nth10sd] from comment #0)

Nicolas, do you think you can add this? --ion-warmup-threshold=0 seems to find some issues that --ion-warmup-threshold=100 does not catch.

(I'm not sure if =0 finds all of the issues that =100 also finds though, i.e. I'm not sure if the =100 set of bugs is a subset of the =0 ones. Hence I'm not sure if they are either/or or we should have both)

Honestly I thought --ion-eager would be similar to --ion-warmup-threshold=0, but I guess that --ion-eager might be similar to --ion-warmup-threshold=1.

I think --ion-warmup-threshold=100 still makes sense as it will compile after TI collection of various type observation from Baseline. These eager mode would miss cases where Baseline observes more than one type.

Assignee

Updated

4 months ago
Flags: needinfo?(nicolas.b.pierron)

Comment 3

4 months ago
Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e0f409bac9bd
JS Fuzzing: Add flag to fuzz harder than --ion-eager. r=jandem

Comment 4

4 months ago
bugherder
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → nicolas.b.pierron
You need to log in before you can comment on or make changes to this bug.