1529079 - Intermittent AttributeError: 'NoneType' object has no attribute 'pid'

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P1)

Description

[Treeherder Bug Filer]

#[markdown(off)]
Filed by: bclary [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=229181906&repo=mozilla-central

https://queue.taskcluster.net/v1/task/GJo2ESOxSSiABGGvkhV-SQ/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Bob Clary [:bc] (inactive)]

11:24:57 INFO - raptor-control-server received webext_status: __raptor_shutdownBrowser
11:24:57 ERROR - Traceback (most recent call last):
11:24:57 INFO - File "/usr/lib/python2.7/SocketServer.py", line 290, in _handle_request_noblock
11:24:57 INFO - self.process_request(request, client_address)
11:24:57 INFO - File "/usr/lib/python2.7/SocketServer.py", line 318, in process_request
11:24:57 INFO - self.finish_request(request, client_address)
11:24:57 INFO - File "/usr/lib/python2.7/SocketServer.py", line 331, in finish_request
11:24:57 INFO - self.RequestHandlerClass(request, client_address, self)
11:24:57 INFO - File "/builds/worker/workspace/build/tests/raptor/raptor/control_server.py", line 30, in init
11:24:57 INFO - super(MyHandler, self).init(*args, **kwargs)
11:24:57 INFO - File "/usr/lib/python2.7/SocketServer.py", line 652, in init
11:24:57 INFO - self.handle()
11:24:57 INFO - File "/usr/lib/python2.7/BaseHTTPServer.py", line 340, in handle
11:24:57 INFO - self.handle_one_request()
11:24:57 INFO - File "/usr/lib/python2.7/BaseHTTPServer.py", line 328, in handle_one_request
11:24:57 INFO - method()
11:24:57 INFO - File "/builds/worker/workspace/build/tests/raptor/raptor/control_server.py", line 82, in do_POST
11:24:57 INFO - self.shutdown_browser()
11:24:57 INFO - File "/builds/worker/workspace/build/tests/raptor/raptor/control_server.py", line 153, in shutdown_browser
11:24:57 INFO - LOG.info("shutting down browser (pid: %d)" % self.browser_proc.pid)
11:24:57 INFO - AttributeError: 'NoneType' object has no attribute 'pid'

Comment 2

[Robert Wood [:rwood]]

I can reproduce this locally on my GP2... I'll make a fix.

Comment 3

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=42f381752e83679d79091994c4968c813ffce739

Comment 4

[Robert Wood [:rwood]]

Attachment: Bug 1529079 - Fix fennec shutdown; r?davehunt

Comment 5

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=68fff9d50a53e37f561369dbbc35125e7afe0917

Comment 6

[Robert Wood [:rwood]]

Attachment: Bug 1529079 - Fix Raptor fennec shutdown failure; r?bc

Comment 7

[Robert Wood [:rwood]]

With update merging the one method (thanks for the feedback :bc!)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e64bcddaf88ea4f941c55e6ebe1980546c1e7431

Comment 8

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7502a5344ae47be073238b9c2ad78d2e7e3e84b3

Comment 9

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d6a846d68c16c46f6d68dabbcb1c0bc4325518e

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ec1ba39a978
Fix Raptor fennec shutdown failure; r=bc

Comment 11

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/9ec1ba39a978

Comment 12

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/9ec1ba39a978

Comment 13

[Intermittent Failures Robot]

4 failures in 2602 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 4

Platform breakdown:

• android-hw-p2-8-0-arm7-api-16-nightly: 2
• android-hw-p2-8-0-android-aarch64-nightly: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1529079&startday=2019-02-18&endday=2019-02-24&tree=all