Closed Bug 1529080 Opened 9 months ago Closed 8 months ago

[wpt-sync] Sync PR 15398 - Restrict Device{Orientation|Motion}Events to secure origins.

Categories

(Core :: DOM: Device Interfaces, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15398 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15398
Details from upstream follow.

Balazs Engedy <engedy@chromium.org> wrote:

Restrict Device{Orientation|Motion}Events to secure origins.

Registering event handlers to devicemotion, deviceorientation,
and deviceorientationabsolute events is still possible, but the
handlers will never be invoked in non-secure browsing contexts.

The following, related, interfaces are marked as [SecureContext]:
-- DeviceOrientationEvent,
-- DeviceMotionEvent,
-- DeviceMotionEventAcceleration,
-- DeviceMotionEventRotationRate.

The change is gated on RestrictDeviceSensorEventsToSecureContexts,
which is disabled by default, so this CL is a no-op unless the
base::Feature with the same name is manually enabled.

Intent to remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/5yqfAXibz1I

Bug: 932078
Change-Id: I9baaafd1f4483f121feadc054650c4d510a2c88d

Reviewed-on: https://chromium-review.googlesource.com/1473992
WPT-Export-Revision: 6230221e3862ee6968517cad9b1603a6fc774cc8

Component: web-platform-tests → DOM: Device Interfaces
Product: Testing → Core
Ran 4 tests and 8 subtests
OK     : 3
PASS   : 3
FAIL   : 4
TIMEOUT: 1
NOTRUN : 1

New tests that have failures or other problems:
/orientation-event/devicemotionevent-init.https.html
    User created event is initialized properly with default values: FAIL
/orientation-event/deviceorientationabsoluteevent.https.html: TIMEOUT
    deviceorientationabsolute event fires: NOTRUN
/orientation-event/ondeviceorientationabsolute.https.html
    Provide an event handler IDL attribute named ondeviceorientationabsolute: FAIL
    The absolute property must be set to true.: FAIL
    The type of this event handler must be 'DeviceOrientationEvent': FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/17b00ba4a020
[wpt PR 15398] - Restrict Device{Orientation|Motion}Events to secure origins., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/375113eacb17
[wpt PR 15398] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1b3b233b7b8
[wpt PR 15398] - Restrict Device{Orientation|Motion}Events to secure origins., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/f80199c17ea7
[wpt PR 15398] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.