Closed Bug 1529089 Opened 5 years ago Closed 5 years ago

spBefore_ can be left uninitialized in AutoGeckoProfilerEntry::AutoGeckoProfilerEntry()

Categories

(Core :: Gecko Profiler, enhancement)

Product:
Core
Component:
Gecko Profiler
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1529089 - Initialize spBefore_ even if profiler_ will be set to nullptr;
47 bytes, text/x-phabricator-request
Details | Review

If we end up taking this branch https://searchfox.org/mozilla-central/rev/93905b660fc99a5d52b683690dd26471daca08c8/js/src/vm/GeckoProfiler-inl.h#87 then spBefore_ will be left uninitialized.

Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3762aa77369f
Initialize spBefore_ even if profiler_ will be set to nullptr; r=mstange

Backed out changeset 3762aa77369f (bug 1529089) for build bustage at build/src/js/src/vm/GeckoProfiler-inl.h

Backout: https://hg.mozilla.org/integration/autoland/rev/ab11369b0f9699b1badda1e8f757dc1a6ff159b6

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=3762aa77369fb272030521e91a2eae0e6d113bae&selectedJob=229315026

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=229315026&repo=autoland&lineNumber=5097

[task 2019-02-19T22:50:43.129Z] 22:50:43 INFO - config/external/nspr/pr/os_Linux_x86_64.o
[task 2019-02-19T22:50:43.130Z] 22:50:43 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/gcc -std=gnu99 -o os_Linux_x86_64.o -fPIC -Wa,--noexecstack -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -g -c /builds/worker/workspace/build/src/nsprpub/pr/src/md/unix/os_Linux_x86_64.s
[task 2019-02-19T22:50:43.131Z] 22:50:43 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/config/external/nspr/pr'
[task 2019-02-19T22:50:43.131Z] 22:50:43 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/config/external/nspr/pr'
[task 2019-02-19T22:50:43.131Z] 22:50:43 INFO - config/external/nspr/pr/libnspr4.so
[task 2019-02-19T22:50:43.131Z] 22:50:43 INFO - rm -f libnspr4.so
[task 2019-02-19T22:50:43.131Z] 22:50:43 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/config/external/nspr/pr'
[task 2019-02-19T22:50:43.164Z] 22:50:43 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/js/src/gc'
[task 2019-02-19T22:50:43.168Z] 22:50:43 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o Unified_cpp_js_src_gc0.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DWASM_HUGE_MEMORY -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DJS_HAS_CTYPES -DFFI_BUILDING -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src/gc -I/builds/worker/workspace/build/src/obj-firefox/js/src/gc -I/builds/worker/workspace/build/src/obj-firefox/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/js/src/js-confdefs.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -MD -MP -MF .deps/Unified_cpp_js_src_gc0.o.pp /builds/worker/workspace/build/src/obj-firefox/js/src/gc/Unified_cpp_js_src_gc0.cpp
[task 2019-02-19T22:50:43.169Z] 22:50:43 INFO - In file included from /builds/worker/workspace/build/src/js/src/gc/GC.cpp:254:0,
[task 2019-02-19T22:50:43.170Z] 22:50:43 INFO - from /builds/worker/workspace/build/src/obj-firefox/js/src/gc/Unified_cpp_js_src_gc0.cpp:29:
[task 2019-02-19T22:50:43.170Z] 22:50:43 INFO - /builds/worker/workspace/build/src/js/src/vm/GeckoProfiler-inl.h: In constructor 'js::GeckoProfilerEntryMarker::GeckoProfilerEntryMarker(JSContext*, JSScript*, mozilla::detail::GuardObjectNotifier&&)':
[task 2019-02-19T22:50:43.170Z] 22:50:43 ERROR - /builds/worker/workspace/build/src/js/src/vm/GeckoProfiler-inl.h:56:17: error: cannot convert 'std::nullptr_t' to 'uint32_t {aka unsigned int}' in assignment
[task 2019-02-19T22:50:43.170Z] 22:50:43 INFO - spBefore_ = nullptr;
[task 2019-02-19T22:50:43.170Z] 22:50:43 INFO - ^~~~~~~
[task 2019-02-19T22:50:43.170Z] 22:50:43 INFO - /builds/worker/workspace/build/src/js/src/vm/GeckoProfiler-inl.h: In constructor 'js::AutoGeckoProfilerEntry::AutoGeckoProfilerEntry(JSContext*, const char*, JS::ProfilingCategoryPair, uint32_t, mozilla::detail::GuardObjectNotifier&&)':
[task 2019-02-19T22:50:43.170Z] 22:50:43 ERROR - /builds/worker/workspace/build/src/js/src/vm/GeckoProfiler-inl.h:92:17: error: cannot convert 'std::nullptr_t' to 'uint32_t {aka unsigned int}' in assignment
[task 2019-02-19T22:50:43.170Z] 22:50:43 INFO - spBefore_ = nullptr;
[task 2019-02-19T22:50:43.170Z] 22:50:43 INFO - ^~~~~~~
[task 2019-02-19T22:50:43.170Z] 22:50:43 INFO - /builds/worker/workspace/build/src/config/rules.mk:805: recipe for target 'Unified_cpp_js_src_gc0.o' failed
[task 2019-02-19T22:50:43.170Z] 22:50:43 ERROR - make[4]: *** [Unified_cpp_js_src_gc0.o] Error 1
[task 2019-02-19T22:50:43.170Z] 22:50:43 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/js/src/gc'
[task 2019-02-19T22:50:43.170Z] 22:50:43 INFO - make[4]: *** Waiting for unfinished jobs....
[task 2019-02-19T22:50:43.170Z] 22:50:43 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/js/src/jit'
[task 2019-02-19T22:50:43.170Z] 22:50:43 INFO - js/src/jit/Unified_cpp_js_src_jit6.o
[task 2019-02-19T22:50:43.170Z] 22:50:43 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/js/src/jit'
[task 2019-02-19T22:50:43.203Z] 22:50:43 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/js/src/gc'
[task 2019-02-19T22:50:43.203Z] 22:50:43 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o Unified_cpp_js_src_gc2.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DWASM_HUGE_MEMORY -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DJS_HAS_CTYPES -DFFI_BUILDING -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src/gc -I/builds/worker/workspace/build/src/obj-firefox/js/src/gc -I/builds/worker/workspace/build/src/obj-firefox/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/js/src/js-confdefs.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -MD -MP -MF .deps/Unified_cpp_js_src_gc2.o.pp /builds/worker/workspace/build/src/obj-firefox/js/src/gc/Unified_cpp_js_src_gc2.cpp
[task 2019-02-19T22:50:43.204Z] 22:50:43 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/js/src/gc'
[task 2019-02-19T22:50:43.204Z] 22:50:43 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'js/src/gc/target' failed
[task 2019-02-19T22:50:43.204Z] 22:50:43 ERROR - make[3]: *** [js/src/gc/target] Error 2
[task 2019-02-19T22:50:43.204Z] 22:50:43 INFO - make[3]: *** Waiting for unfinished jobs....
[task 2019-02-19T22:50:43.204Z] 22:50:43 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/js/src/jit'
[task 2019-02-19T22:50:43.204Z] 22:50:43 INFO - js/src/jit/Unified_cpp_js_src_jit7.o
[task 2019-02-19T22:50:43.205Z] 22:50:43 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/js/src/jit'
[task 2019-02-19T22:50:43.220Z] 22:50:43 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/config/external/nspr/pr'
[task 2019-02-19T22:50:43.221Z] 22:50:43 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/gcc -std=gnu99 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -fPIC -shared -Wl,-z,defs -Wl,--gc-sections -Wl,-h,libnspr4.so -o libnspr4.so prfdcach.o priometh.o pripv6.o prlayer.o prlog.o prmapopt.o prmmap.o prmwait.o prpolevt.o prprf.o prscanf.o prstdio.o prlink.o prmalloc.o prmem.o prosdep.o linux.o unix.o unix_errors.o uxproces.o uxrng.o uxshm.o uxwrap.o prseg.o prshm.o prshma.o pralarm.o pratom.o praton.o prcountr.o prdtoa.o prenv.o prerr.o prerror.o prerrortable.o prinit.o prinrval.o pripc.o prlog2.o prlong.o prnetdb.o prolock.o prrng.o prsystem.o prthinfo.o prtime.o prtpool.o prtrace.o ptio.o ptmisc.o ptsynch.o ptthread.o prcmon.o prrwlock.o prtpd.o os_Linux_x86_64.o -lpthread -Wl,-z,noexecstack -Wl,-z,text -Wl,-z,relro -Wl,-z,nocopyreloc -Wl,-Bsymbolic-functions -Wl,--build-id=sha1 -Wl,-rpath-link,/builds/worker/workspace/build/src/obj-firefox/dist/bin -Wl,-rpath-link,/usr/local/lib -ldl -lrt
[task 2019-02-19T22:50:43.221Z] 22:50:43 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/config/external/nspr/pr'
[task 2019-02-19T22:50:43.342Z] 22:50:43 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/config/external/nspr/pr'
[task 2019-02-19T22:50:43.342Z] 22:50:43 INFO - /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python -m mozbuild.action.check_binary --target libnspr4.so
[task 2019-02-19T22:50:43.342Z] 22:50:43 INFO - TEST-PASS | check_stdcxx | libnspr4.so
[task 2019-02-19T22:50:43.342Z] 22:50:43 INFO - TEST-PASS | check_libgcc | libnspr4.so
[task 2019-02-19T22:50:43.342Z] 22:50:43 INFO - TEST-PASS | check_glibc | libnspr4.so
[task 2019-02-19T22:50:43.343Z] 22:50:43 INFO - TEST-PASS | check_textrel | libnspr4.so

Flags: needinfo?(ehsan)
Assignee: nobody → ehsan

Hah oops, I didn't look at the type of that variable...

Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6ff327fca53
Initialize spBefore_ even if profiler_ will be set to nullptr; r=mstange

https://hg.mozilla.org/mozilla-central/rev/a6ff327fca53

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: