1529176 - always use our modified arc fork from moz-phab

Status: RESOLVED FIXED

(Conduit :: moz-phab, enhancement, P3)

Description

[:glob ✱]

in order to address some issues with arc, mostly around prompting, we'll be lightly forking it (see bug 1529175).

this bug is to update moz-phab to automatically clone and update this fork.

• git will be required to use moz-phab
• the first-run experience will involve cloning the arcanist and libphutil repos into ~/.mozbuild/moz-phab/
• removal of the arc_command setting
• updating install docs

Comment 1

[Piotr Zalewa [:zalun]]

We should somehow work around the install-certificate feature.
When there is no other arc installed user would need to ~/.mozbuild/moz-phab/arcanist/bin/arc install-certificate

Comment 2

[:glob ✱]

(In reply to Piotr Zalewa [:zalun] from comment #1)

We should somehow work around the install-certificate feature.
When there is no other arc installed user would need to ~/.mozbuild/moz-phab/arcanist/bin/arc install-certificate

should be straight forward to check ~/.arcrc if the current hostname is present, and call arc install-certificate.

just need to ensure we check the right file on windows; probably best to look at arc's logic to determine how it finds/names arcrc.

Comment 3

[Piotr Zalewa [:zalun]]

Calling arc install-certificate would require filling in the prompt.
Currently, I'm displaying the command with a full path to our arc.
I think we should write directly to ~/.arcrc.
I will submit WIP to Phabricator.

Comment 4

[Piotr Zalewa [:zalun]]

Attachment: Bug 1529176 - Use special arc version r=glob