1529204 - Fix warnings triggered when building glean and sample-glean

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P3)

Description

[Alessio Placitelli [:Dexter]]

Building glean and the companion sample app produces a bunch of warnings that should be fix. This bug is for dealing with them.

Comment 1

[Michael Droettboom [:mdroettboom]]

The warnings on master as of right now:

> Task :service-glean:compileDebugKotlin
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/BooleanMetricType.kt: (47, 18): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/BooleanMetricType.kt: (47, 30): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/CounterMetricType.kt: (60, 18): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/CounterMetricType.kt: (60, 30): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/DatetimeMetricType.kt: (49, 18): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/DatetimeMetricType.kt: (49, 30): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/DatetimeMetricType.kt: (74, 18): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/DatetimeMetricType.kt: (74, 30): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/EventMetricType.kt: (105, 18): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/EventMetricType.kt: (105, 30): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/Glean.kt: (231, 29): 'versionCode: Int' is deprecated. Deprecated in Java
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/LabeledMetricType.kt: (132, 68): Unchecked cast: BooleanMetricType to T
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/LabeledMetricType.kt: (133, 68): Unchecked cast: CounterMetricType to T
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/LabeledMetricType.kt: (134, 69): Unchecked cast: DatetimeMetricType to T
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/LabeledMetricType.kt: (135, 71): Unchecked cast: StringListMetricType to T
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/LabeledMetricType.kt: (136, 67): Unchecked cast: StringMetricType to T
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/LabeledMetricType.kt: (137, 69): Unchecked cast: TimespanMetricType to T
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/LabeledMetricType.kt: (138, 65): Unchecked cast: UuidMetricType to T
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/StringListMetricType.kt: (73, 18): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/StringListMetricType.kt: (73, 30): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/StringListMetricType.kt: (108, 18): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/StringListMetricType.kt: (108, 30): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/StringMetricType.kt: (68, 18): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/StringMetricType.kt: (68, 30): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/UuidMetricType.kt: (66, 18): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/UuidMetricType.kt: (66, 30): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/error/ErrorRecording.kt: (87, 9): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/error/ErrorRecording.kt: (87, 21): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/ping/BaselinePing.kt: (16, 29): Parameter 'applicationContext' is never used
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/storages/StorageEngineManager.kt: (141, 63): No cast needed
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/storages/StorageEngineManager.kt: (142, 63): No cast needed
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/storages/StorageEngineManager.kt: (143, 65): No cast needed
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/storages/StorageEngineManager.kt: (144, 69): No cast needed
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/storages/StorageEngineManager.kt: (145, 61): No cast needed
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/storages/StorageEngineManager.kt: (146, 65): No cast needed
w: android-components/components/service/glean/src/main/java/mozilla/components/service/glean/storages/StorageEngineManager.kt: (147, 57): No cast needed
> Task :service-glean:compileDebugUnitTestKotlin
w: android-components/components/service/glean/src/test/java/mozilla/components/service/glean/DispatchersTest.kt: (23, 13): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/test/java/mozilla/components/service/glean/DispatchersTest.kt: (23, 25): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: android-components/components/service/glean/src/test/java/mozilla/components/service/glean/debug/GleanDebugActivityTest.kt: (38, 22): 'addResolveInfoForIntent(Intent!, ResolveInfo!): Unit' is deprecated. Deprecated in Java
w: android-components/components/service/glean/src/test/java/mozilla/components/service/glean/ping/PingMakerTest.kt: (142, 53): 'application: Application!' is deprecated. Deprecated in Java
w: android-components/components/service/glean/src/test/java/mozilla/components/service/glean/scheduler/MetricsPingSchedulerTest.kt: (22, 80): 'application: Application!' is deprecated. Deprecated in Java
w: android-components/components/service/glean/src/test/java/mozilla/components/service/glean/storages/EventsStorageEngineTest.kt: (29, 27): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ExperimentalCoroutinesApi' or '@UseExperimental(kotlinx.coroutines.ExperimentalCoroutinesApi::class)'

Comment 2

[Michael Droettboom [:mdroettboom]]

Attachment: GitHub Pull Request

Comment 3

[Michael Droettboom [:mdroettboom]]

Reopening, since some of these warnings have returned.

Comment 4

[Michael Droettboom [:mdroettboom]]

Attachment: GitHub Pull Request

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22d9c80ad1b0
[components] 1529204: Fix compile warnings
https://hg.mozilla.org/integration/autoland/rev/0a65053a9dbe
[components] 1529204: Another round of warning fixing