"Report a Problem" text-link in the identity popup doesn't work anymore
Categories
(Firefox :: Site Identity, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox65 | --- | unaffected |
| firefox66 | --- | unaffected |
| firefox67 | --- | verified |
People
(Reporter: johannh, Assigned: surkov)
References
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
Screenshot 2019-02-20 at 11.11.34.png
The text-link binding for the breakage report link in the identity popup was broken by bug 1527495. It's not a link anymore and can't be clicked (see screenshot).
Alexander, can you take a look at this? Thank you!
|
||
Comment 1•5 years ago
|
||
I wonder if this regressed because it uses [onclick] and not [href]: https://searchfox.org/mozilla-central/rev/4587d146681b16ff9878a6fdcba53b04f76abe1d/browser/components/controlcenter/content/panel.inc.xul#124?
|
Assignee | |
Comment 2•5 years ago
|
||
(In reply to Johann Hofmann [:johannh] from comment #0)
Created attachment 9045183 [details]
Screenshot 2019-02-20 at 11.11.34.pngThe text-link binding for the breakage report link in the identity popup was broken by bug 1527495. It's not a link anymore and can't be clicked (see screenshot).
Alexander, can you take a look at this? Thank you!
what are steps to reproduce?
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #1)
I wonder if this regressed because it uses [onclick] and not [href]: https://searchfox.org/mozilla-central/rev/4587d146681b16ff9878a6fdcba53b04f76abe1d/browser/components/controlcenter/content/panel.inc.xul#124?
it seems there's no point to use text-link CE for this element, no @href, no CE logic is involved. So let's remove it.
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
Reporter | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
Pushed by asurkov@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f0eb49d8d255 'Report a Problem' text-link in the identity popup doesn't work anymore, r=MattN
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
||
Comment 8•5 years ago
|
||
I have reproduced this issue using Firefox 67.0a1 (2019.02.20) Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 67.0b8 on Win 10 x64, macOS 10.14.3 and Ubuntu 18.04 x64.
Description
•