Closed Bug 1529227 Opened 2 years ago Closed 2 years ago

Don't export NSS CMS functions not required by Firefox

Categories

(Core :: Security: PSM, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: KaiE, Assigned: KaiE)

References

Details

Attachments

(1 file)

Most of the NSS_CMSMessage* functions are required by Firefox.

Potentially Firefox could reduce its size, by only exporting the functions it really needs, and have Thunderbird export the rest.

If this is wanted, it depends on a TB bug to export those locally.

In searchfox I see three functions being used by Firefox:

  • Create
  • Destroy
  • GetContentInfo

(In reply to Kai Engert (:kaie:) from comment #0)

Most of the NSS_CMSMessage* functions are required by Firefox.

NOT

Depends on: 1529228

Hi Dana, this is just a suggestion, please let me know if you like to do it.

Flags: needinfo?(dkeeler)

Sure - sounds good to me.

Flags: needinfo?(dkeeler)

FYI, the NSS_InitReadWrite function is a one-line wrapper around another NSS init function, and you mentioned in bug 1529222 that it's ok to export HASH_GetHashOidTagByHashType.

FYI, the remaining functions NSS_CMS* functions are still required by Firefox and tests. For example, there's a AsPKCS7Blob function that's used in tests.

Comment on attachment 9046694 [details] [diff] [review]
1529227-v2.patch

Review of attachment 9046694 [details] [diff] [review]:
-----------------------------------------------------------------

Great - thanks!
Attachment #9046694 - Flags: review?(dkeeler) → review+
Pushed by kaie@kuix.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a31acecd0372
Don't export NSS CMS functions not required by Firefox, r=keeler
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.