Closed Bug 1529238 Opened 8 months ago Closed 7 months ago

Error running ./mach test --verify with crashtest: TypeError: __getnewargs__ should return a tuple, not 'unicode'

Categories

(Testing :: General, defect, P2)

Version 3
defect

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: valentin, Assigned: gbrown)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

icecold@icecold-tp:~/mozilla-central$ ./mach test --verify xpcom/string/crashtests/1113005.html
0:00.17 INFO :::
0:00.17 INFO ::: Running test verification step "1. Run each test 10 times in one browser."...
0:00.17 INFO :::
Error running mach:

['test', '--verify', 'xpcom/string/crashtests/1113005.html']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: __getnewargs__ should return a tuple, not 'unicode'

  File "/home/icecold/mozilla-central/testing/mach_commands.py", line 169, in test
    argv=extra_args, test_objects=tests, **kwargs)
  File "/home/icecold/mozilla-central/python/mach/mach/registrar.py", line 138, in dispatch
    return self._run_command_handler(handler, context=context, **kwargs)
  File "/home/icecold/mozilla-central/python/mach/mach/registrar.py", line 95, in _run_command_handler
    result = fn(**kwargs)
  File "/home/icecold/mozilla-central/layout/tools/reftest/mach_commands.py", line 230, in run_crashtest
    return self._run_reftest(**kwargs)
  File "/home/icecold/mozilla-central/layout/tools/reftest/mach_commands.py", line 244, in _run_reftest
    return reftest.run_desktop_test(**kwargs)
  File "/home/icecold/mozilla-central/layout/tools/reftest/mach_commands.py", line 91, in run_desktop_test
    rv = runreftest.run_test_harness(parser, args)
  File "/home/icecold/mozilla-central/layout/tools/reftest/runreftest.py", line 962, in run_test_harness
    result = reftest.verifyTests(options.tests, options)
  File "/home/icecold/mozilla-central/layout/tools/reftest/runreftest.py", line 530, in verifyTests
    result = step()
  File "/home/icecold/mozilla-central/layout/tools/reftest/runreftest.py", line 471, in step1
    stepOptions = copy.deepcopy(options)
  File "/usr/lib/python2.7/copy.py", line 190, in deepcopy
    y = _reconstruct(x, rv, 1, memo)
  File "/usr/lib/python2.7/copy.py", line 334, in _reconstruct
    state = deepcopy(state, memo)
  File "/usr/lib/python2.7/copy.py", line 163, in deepcopy
    y = copier(x, memo)
  File "/usr/lib/python2.7/copy.py", line 257, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
  File "/usr/lib/python2.7/copy.py", line 190, in deepcopy
    y = _reconstruct(x, rv, 1, memo)
  File "/usr/lib/python2.7/copy.py", line 334, in _reconstruct
    state = deepcopy(state, memo)
  File "/usr/lib/python2.7/copy.py", line 163, in deepcopy
    y = copier(x, memo)
  File "/usr/lib/python2.7/copy.py", line 257, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
  File "/usr/lib/python2.7/copy.py", line 190, in deepcopy
    y = _reconstruct(x, rv, 1, memo)
  File "/usr/lib/python2.7/copy.py", line 334, in _reconstruct
    state = deepcopy(state, memo)
  File "/usr/lib/python2.7/copy.py", line 163, in deepcopy
    y = copier(x, memo)
  File "/usr/lib/python2.7/copy.py", line 257, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
  File "/usr/lib/python2.7/copy.py", line 163, in deepcopy
    y = copier(x, memo)
  File "/usr/lib/python2.7/copy.py", line 230, in _deepcopy_list
    y.append(deepcopy(a, memo))
  File "/usr/lib/python2.7/copy.py", line 190, in deepcopy
    y = _reconstruct(x, rv, 1, memo)
  File "/usr/lib/python2.7/copy.py", line 334, in _reconstruct
    state = deepcopy(state, memo)
  File "/usr/lib/python2.7/copy.py", line 163, in deepcopy
    y = copier(x, memo)
  File "/usr/lib/python2.7/copy.py", line 257, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
  File "/usr/lib/python2.7/copy.py", line 163, in deepcopy
    y = copier(x, memo)
  File "/usr/lib/python2.7/copy.py", line 230, in _deepcopy_list
    y.append(deepcopy(a, memo))
  File "/usr/lib/python2.7/copy.py", line 190, in deepcopy
    y = _reconstruct(x, rv, 1, memo)
  File "/usr/lib/python2.7/copy.py", line 334, in _reconstruct
    state = deepcopy(state, memo)
  File "/usr/lib/python2.7/copy.py", line 163, in deepcopy
    y = copier(x, memo)
  File "/usr/lib/python2.7/copy.py", line 257, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
  File "/usr/lib/python2.7/copy.py", line 190, in deepcopy
    y = _reconstruct(x, rv, 1, memo)
  File "/usr/lib/python2.7/copy.py", line 334, in _reconstruct
    state = deepcopy(state, memo)
  File "/usr/lib/python2.7/copy.py", line 163, in deepcopy
    y = copier(x, memo)
  File "/usr/lib/python2.7/copy.py", line 257, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
  File "/usr/lib/python2.7/copy.py", line 182, in deepcopy
    rv = reductor(2)
Assignee: nobody → gbrown
Priority: -- → P2

I have the same experience with the reported crashtest. xpcshell, reftests seem okay.

(In reply to Geoff Brown [:gbrown] from comment #1)

I have the same experience with the reported crashtest. xpcshell, reftests seem okay.

Sorry, that's wrong: all reftests fail with --verify. Other suites seem okay.

copy.deepcopy is failing on options.log

mach reftest <test> --verify is OK / mach test <test> --verify FAILS.

Blocks: test-verify

Remove the troublesome log options once they have been used.

Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/981a62a09810
Avoid TypeError in 'mach test <reftest> --verify'; r=bc
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.