Closed Bug 1529273 Opened 1 year ago Closed 1 year ago

Make Profile::new not take an Option<&Path>

Categories

(Testing :: Mozbase Rust, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: ato, Assigned: kritisingh1.ks)

Details

(Keywords: good-first-bug)

Attachments

(2 files)

Instead of Profile::new() taking an Option&lt;&Path> as argument,
we should have dedicated ::new() and ::new_from_path(&Path)
functions.

This would involve changing both capabilities.rs and marionette.rs,
along with some unit test changes.

You can read more about working on geckodriver here:
https://firefox-source-docs.mozilla.org/testing/geckodriver/index.html

Mentor: ato
Keywords: good-first-bug
Whiteboard: [lang=rust]
Mentor: ato
Whiteboard: [lang=rust]

Hi. May I take up this issue? Thanks!

Certainly! Here are some links that are useful to get started:

I am also on #interop on irc.mozilla.org in case you have any questions.

Assignee: nobody → kritisingh1.ks
Status: NEW → ASSIGNED

Hi Andreas. So I am stuck at building geckodriver for a while now. It seems to have a lot of dependencies and don't seem to end even after I installed 10-12 of them as per consecutive error messages. Could you point me to a documentation which contains the list of all the required dependencies for the project? Also, a few among them like nasm 2.13 and gconf-2.0 require to be installed in the root folder manually. Is that the right way or I am missing something? Thanks

After you’ve cloned the repo, running ./mach bootstrap will ensure
all the dependencies are correctly installed. Following that you
need to run ./mach configure before you can build geckodriver
with ./mach build testing/geckodriver.

Alternatively you can use the regular Rust approach with cargo build in testing/geckodriver.

Let me know if this helps.

This patch replaces the current implementation of Profile::new() taking an Option<&Path> as argument with dedicated Profile::new() and Profile::new_from_path(opt_path: Option<&Path>) functions.

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9f0635581b5c
replaces the current implementation of Profile::new with dedicated Profile::new and Profile::new_from_path. r=ato
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.