1529273 - Make Profile::new not take an Option<&Path>

Status: RESOLVED FIXED

(Testing :: Mozbase Rust, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

Instead of Profile::new() taking an Option<&Path> as argument,
we should have dedicated ::new() and ::new_from_path(&Path)
functions.

This would involve changing both capabilities.rs and marionette.rs,
along with some unit test changes.

You can read more about working on geckodriver here:
https://firefox-source-docs.mozilla.org/testing/geckodriver/index.html

Comment 1

[Kriti Singh]

Hi. May I take up this issue? Thanks!

Comment 2

[Andreas Tolfsen ❲:ato❳]

Certainly! Here are some links that are useful to get started:

• General Gecko development: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction
• geckodriver development: https://firefox-source-docs.mozilla.org/testing/geckodriver/index.html#for-developers
• Submitting patches: https://moz-conduit.readthedocs.io/en/latest/

I am also on #interop on irc.mozilla.org in case you have any questions.

Comment 3

[Kriti Singh]

Hi Andreas. So I am stuck at building geckodriver for a while now. It seems to have a lot of dependencies and don't seem to end even after I installed 10-12 of them as per consecutive error messages. Could you point me to a documentation which contains the list of all the required dependencies for the project? Also, a few among them like nasm 2.13 and gconf-2.0 require to be installed in the root folder manually. Is that the right way or I am missing something? Thanks

Comment 4

[Andreas Tolfsen ❲:ato❳]

After you’ve cloned the repo, running ./mach bootstrap will ensure
all the dependencies are correctly installed. Following that you
need to run ./mach configure before you can build geckodriver
with ./mach build testing/geckodriver.

Alternatively you can use the regular Rust approach with cargo build in testing/geckodriver.

Let me know if this helps.

Comment 5

[Kriti Singh]

Attachment: Profile creation: uses dedicated new and new_from_path functions

This patch replaces the current implementation of Profile::new() taking an Option<&Path> as argument with dedicated Profile::new() and Profile::new_from_path(opt_path: Option<&Path>) functions.

Comment 6

[Kriti Singh]

Attachment: Bug 1529273 - replaces the current implementation of Profile::new with dedicated Profile::new and Profile::new_from_path. r=ato

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f0635581b5c
replaces the current implementation of Profile::new with dedicated Profile::new and Profile::new_from_path. r=ato

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9f0635581b5c