Support searching for Nightly’s default path on macOS
Categories
(Testing :: Mozbase Rust, enhancement, P1)
Tracking
(firefox67 fixed)
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: ato, Assigned: kritisingh1.ks)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
mozrunner is able to suggest where Firefox is installed on the
system. This is used by geckodriver when a user creates a new
WebDriver session without specifying a binary path.
If Firefox stable is not installed, it would be useful if mozrunner
could look for Firefox Nightly and suggest that instead. The default
installation paths for Nightly on macOS are:
- /Applications/Firefox Nightly.app
- $HOME/Applications/Firefox Nightly.app
This would require a change to runner.rs:
https://searchfox.org/mozilla-central/rev/93905b660fc99a5d52b683690dd26471daca08c8/testing/mozbase/rust/mozrunner/src/runner.rs#329
It would be good if we could generalise this code so that we don’t
end up doing a four-level deep recursion but instead check against
a list. The list should be, in order:
- /Applications/Firefox.app
- $HOME/Applications/Firefox.app
- /Applications/Firefox Nightly.app
- $HOME/Applications/Firefox Nightly.app
Various documentation, such as
https://developer.mozilla.org/en-US/docs/Web/WebDriver/Capabilities/firefoxOptions
and
https://firefox-source-docs.mozilla.org/testing/geckodriver/Capabilities.html
should also be updated as part of this change.
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 2•5 years ago
|
||
(In reply to hafsa from comment #1)
Hello! I'm an Outreachy applicant. Can I claim this bug ?
Yes, you can work on this. The way this usually works is that you
submit a patch and then we assign the bug to you.
You will find a guide to get you prepared for Gecko development
here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide
And then there is more specific documentation to work with geckodriver
(which uses mozrunner) here:
https://firefox-source-docs.mozilla.org/testing/geckodriver/index.html#for-developers
I’m in #interop on irc.mozilla.org as "ato" if you have any questions
or doubts.
Assignee | ||
Comment 4•5 years ago
|
||
Hi! Since this is not active, I am starting to work on this. Thanks!
Assignee | ||
Comment 5•5 years ago
|
||
Reporter | ||
Updated•5 years ago
|
Pushed by ato@sny.no: https://hg.mozilla.org/integration/mozilla-inbound/rev/b4485dab9976 mozrunner: support searching for Nightly’s default path on macOS. r=ato
Comment 7•5 years ago
|
||
bugherder |
Description
•