Open Bug 1529283 Opened 4 years ago Updated 6 months ago

nsAnonTempFileRemover::RemoveAnonTempFileFiles does main thread I/O off a timer

Categories

(Core :: XPCOM, enhancement, P3)

Product:
Core
Component:
XPCOM
Type:
enhancement

Tracking

()

Project Flags:
Performance Impact low

People

(Reporter: florian, Unassigned)

References

Details

(Keywords: main-thread-io, perf, perf:resource-use, Whiteboard: [fxperf:p3][bhr:nsAnonTempFileRemover::RemoveAnonTempFileFiles])

Here is a profile of it: https://perfht.ml/2DW0lxB

Apparently we do main thread I/O off a timer to create a folder to then be able to remove it, with the goal of removing the folder content if the folder existed.

I think this should be done off main thread. And it would be better if we could avoid creating the folder (which creates all the folders in the path recursively) to remove it.

Priority: -- → P3
Whiteboard: [fxperf][qf] → [fxperf][qf:p3:resource]
Whiteboard: [fxperf][qf:p3:resource] → [fxperf:p3][qf:p3:resource]

I saw this again in a profile today: https://share.firefox.dev/2Q0R0Lw

Keywords: main-thread-io, perf
Whiteboard: [fxperf:p3][qf:p3:resource] → [fxperf:p3][qf:p3:resource][bhr:nsAnonTempFileRemover::RemoveAnonTempFileFiles]
Performance Impact: --- → P3
Keywords: perf:resource-use
Whiteboard: [fxperf:p3][qf:p3:resource][bhr:nsAnonTempFileRemover::RemoveAnonTempFileFiles] → [fxperf:p3][bhr:nsAnonTempFileRemover::RemoveAnonTempFileFiles]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.