Rename Cookie::httpOnly to ::http_only

RESOLVED FIXED in Firefox 67

Status

enhancement
P1
normal
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: ato, Assigned: championshuttler)

Tracking

({good-first-bug})

Version 3
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 months ago

The Cookie::httpOnly field should be renamed http_only (with
underscore).

This requires a special serde directive so it knows to deserialise
to and fro the JSON field name httpOnly.

(Reporter)

Updated

2 months ago
Keywords: good-first-bug

Hi Andreas, I would like to work on it , I build the firefox locally and laptop already.

Flags: needinfo?(ato)
(Reporter)

Comment 2

2 months ago

(In reply to Shivam Singhal [ :championshuttler ] from comment #1)

Hi Andreas, I would like to work on it , I build the firefox
locally and laptop already.

Try to see if you can upload the patch for this to Phabricator. It
requires a bit of perseverance, but the gist of getting the compile
environment set up is outlined in
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction,
and Phabricator (MozReview) is documented in
https://moz-conduit.readthedocs.io/en/latest/.

Flags: needinfo?(ato)
(Assignee)

Updated

2 months ago
Assignee: nobody → shivams2799
Attachment #9047628 - Attachment description: Bug 1529285 - Rename Cookie::httpOnly to ::http_only, r=ato → Bug 1529285 - Rename Cookie::httpOnly to ::http_only. r=ato
Attachment #9047628 - Attachment description: Bug 1529285 - Rename Cookie::httpOnly to ::http_only. r=ato → Bug 1529285 - Rename Cookie::httpOnly to ::http_only, r=ato
Attachment #9047628 - Attachment description: Bug 1529285 - Rename Cookie::httpOnly to ::http_only, r=ato → Bug 1529285 - Rename Cookie::httpOnly to ::http_only. r=ato
Attachment #9047628 - Attachment description: Bug 1529285 - Rename Cookie::httpOnly to ::http_only. r=ato → Bug 1529285 - Rename Cookie::httpOnly to ::http_only, r=ato
Attachment #9047628 - Attachment description: Bug 1529285 - Rename Cookie::httpOnly to ::http_only, r=ato → Bug 1529285 - Rename Cookie::httpOnly to ::http_only. r=ato
(Reporter)

Updated

2 months ago
Status: NEW → ASSIGNED
Priority: -- → P1

Comment 4

2 months ago
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/070e1065af52
Rename Cookie::httpOnly to ::http_only. r=ato
(Reporter)

Comment 5

2 months ago

Thank you for the contribution!

Yey! Thanks for the help Andrew. Have a great weekend!

Best
Shivam

Comment 7

a month ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

== Change summary for alert #19848 (as of Sun, 10 Mar 2019 15:43:18 GMT) ==

Improvements:

4% tp5o_scroll windows7-32 pgo e10s stylo 1.39 -> 1.34

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=19848

(In reply to Florin Strugariu [:Bebe] from comment #8)

== Change summary for alert #19848 (as of Sun, 10 Mar 2019 15:43:18 GMT) ==

Improvements:

4% tp5o_scroll windows7-32 pgo e10s stylo 1.39 -> 1.34

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=19848

This change can't have made a perf improvement to Firefox at all because it's only geckodriver related, and only a variable name was changed.

You need to log in before you can comment on or make changes to this bug.