Remove support for legacy {"ELEMENT": <UUID>} web element objects

RESOLVED FIXED in Firefox 67

Status

enhancement
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: ato, Assigned: championshuttler)

Tracking

(Blocks 2 bugs, {good-first-bug})

Version 3
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 months ago

geckodriver supports legacy {"ELEMENT": <UUID>} Selenium-styled
web element references. These have been removed from most, if not
all, relevant clients and we should also purge it from geckodriver
in preparation of the 1.0 release.

The legacy web element key is defined here:
https://searchfox.org/mozilla-central/rev/93905b660fc99a5d52b683690dd26471daca08c8/testing/geckodriver/src/command.rs#17

And used here:
https://searchfox.org/mozilla-central/source/testing/geckodriver/src/marionette.rs#396

See this for more information working on geckodriver:
https://firefox-source-docs.mozilla.org/testing/geckodriver/

(Reporter)

Updated

2 months ago
Keywords: good-first-bug
(Reporter)

Updated

2 months ago
Blocks: 1489130

This depends on bug 1495063, right?

Depends on: 1495063

Hi :whimboo , :ato , I would like to work on it

Thanks

(Assignee)

Updated

2 months ago
Flags: needinfo?(hskupin)
Flags: needinfo?(ato)
(Reporter)

Comment 4

2 months ago

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] (away 02/28 - 03/03) from comment #1)

This depends on bug 1495063, right?

It shouldn’t be, since that is about not using ad-hoc element
serialisation in communication with Marionette, and this is about
the public-facing {"ELEMENT": "…"} for WebDriver.

No longer depends on: 1495063
Flags: needinfo?(hskupin)
Flags: needinfo?(ato)

Comment 5

2 months ago
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b62eba3cf3b6
Remove support for legacy {ELEMENT: <UUID>} web element objects. r=ato
(Assignee)

Updated

2 months ago
Assignee: nobody → shivams2799

Comment 6

2 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.