1529313 - Taskcluster 6.0.0 requirements breaking PyUP tests

Status: RESOLVED FIXED

(Taskcluster :: General, enhancement)

Description

[Danut Labici [:dlabici]]

This week SlugID got updated to 2.0.0 and all PyUp PRs are failing because of the following reason:

taskcluster 6.0.0 has requirement slugid<2,>=1.0.7, but you have slugid 2.0.0.

For now I reverted slugid back to 1.0.7 so we can merge the PR(s). This will be a weekly "blocker" to update slugid till either tc requirements gets updated, or we come to another decision such as to pin slugid to 1.0.7

Affected repos: build-puppet, treescript, addonscript

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

John, do you want to just bump the slugid version requirement in tc-client.py?

Comment 2

[John Ford [:jhford] CET/CEST Berlin Time]

It's actually more than just bumping the version in taskcluster-client.py, hashing unicode strings turns out not to work, so I have to fix that before this can be released. As this includes breaking changes for slugid, which is exported, it needs to be a 7.0.0 series release.

Setting a needinfo on myself so I don't forget.

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: PR

Comment 4

[Pete Moore [:pmoore][:pete]]

I've landed the taskcluster-client.py changes. Do we need to make a release, or do anything else?

Comment 5

[Danut Labici [:dlabici]]

I believe we do, as from what I can see we download modules via versions in requirements.txt
But, I'm not the best guy to answer this (just answered based on experience on working with PyUp)

Comment 6

[Aki Sasaki (not active)]

I just created a 7.0.0 release. I'll patch scriptworker so its slugid usage doesn't break. Looks like I may need taskcluster-client.py admin access to get ./release.sh working properly (for the master head push).

Comment 7

[Aki Sasaki (not active)]

(In reply to Aki Sasaki [:aki] from comment #6)

I'll patch scriptworker so its slugid usage doesn't break.

Looks like this is only in integration tests, so we don't need a new scriptworker release.

Comment 9

[Aki Sasaki (not active)]

I have created a taskcluster 7.0.1 release that removes the upper version pin: https://github.com/taskcluster/taskcluster-client.py/pull/130 . This should help us avoid this type of pyup PR bustage in the future.

I already landed a taskcluster==7.0.0, slugid==2.0.0 fix to puppet: https://github.com/mozilla-releng/build-puppet/pull/431