[wpt-sync] Sync PR 15474 - Mark shadow trees for style collection update when inserted to document

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P4
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [wptsync downstream], )

Assignee

Description

3 months ago

Sync web-platform-tests PR 15474 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15474
Details from upstream follow.

Rakina Zata Amni <rakina@chromium.org> wrote:

Mark shadow trees for style collection update when inserted to document

When we attach shadow trees with non-empty |adoptedStyleSheets|, we
should update the active style sheet collection for that tree scope.
Otherwise, if there are no other stylesheets for that tree scope,
we will never mark the tree scope as dirty and thus have incorrect
style calculation for that tree scope.

Bug: 933578
Change-Id: Id7229b05440a51ac8e5d55570ed030b8cfb707d2
Reviewed-on: https://chromium-review.googlesource.com/1477623
WPT-Export-Revision: 2a0729936101735d6d5f6336527c63e303cfbc2b

Assignee

Updated

3 months ago
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Assignee

Comment 3

3 months ago
Ran 1 tests and 20 subtests
OK     : 1
FAIL   : 20

New tests that have failures or other problems:
/css/cssom/CSSStyleSheet-constructable.html
    Re-attaching shadow host with adopted stylesheets work: FAIL

Comment 4

2 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/629ad93a6738
[wpt PR 15474] - Mark shadow trees for style collection update when inserted to document, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/5de598a7923d
[wpt PR 15474] - Update wpt metadata, a=testonly

Comment 5

2 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/258fdb4dac18
[wpt PR 15474] - Mark shadow trees for style collection update when inserted to document, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/911198c7a3fc
[wpt PR 15474] - Update wpt metadata, a=testonly

Comment 6

2 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.