1529361 - arc continues to check for updates, despite being told not to

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P3)

Description

[Nathan Froyd [:froydnj]]

Indicating that I don't want arc to do upgrades:

froyd@HAWKEYE /c/mozilla-central
$ moz-phab submit --bug 1529355 tip
Version 1.18 of `moz-phab` is now available
Run `moz-phab self-update` to update
Upgrading libphutil...
 Exception
Command failed with error #1!
COMMAND
git rev-parse --git-dir

STDOUT
(empty)

STDERR
'git' is not recognized as an internal or external command,
operable program or batch file.

(Run with `--trace` for a full exception trace.)
arc failed to upgrade, which may be caused by using an arcanist package from
your system package manager.
Would you like to skip arc upgrades in the future? (YES/No)? YES
...proceeds

does not seem to have any effect, as I continue to be prompted about arc upgrades whenever running moz-phab submit.

Comment 1

[:glob ✱]

are you able to provide the contents of your ~/.moz-phab-config file?

Comment 2

[Nathan Froyd [:froydnj]]

Contents of ~/.moz_phab_config:

[ui]
no_ansi = False

[vcs]
safe_mode = False

[arc]
arc_command = arc.bat

[submit]
auto_submit = False
always_blocking = False
warn_untracked = True

[patch]
apply_to = base
create_bookmark = True
always_full_stack = False

[updater]
self_last_check = 1550719597
arc_last_check = 0

Comment 3

[Piotr Zalewa [:zalun]]

Please set arc_last_check to -1
(https://github.com/mozilla-conduit/review#configuration)

Comment 4

[:glob ✱]

(In reply to Piotr Zalewa [:zalun] from comment #3)

Please set arc_last_check to -1
(https://github.com/mozilla-conduit/review#configuration)

that's the workaround for now; however this should have happened automatically due to the response here:

Would you like to skip arc upgrades in the future? (YES/No)? YES

Comment 6

[:glob ✱]

Attachment: Bug 1529361 - fix arc update skip not saving r=zalun

Comment 7

[:glob ✱]

https://github.com/mozilla-conduit/review/commit/a8b464e24d81c8cb18728e4a750f3848fc56e654