[wpt-sync] Sync PR 15179 - Add tentative WPT to verify download in sandbox

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P4
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [wptsync downstream], )

Assignee

Description

3 months ago

Sync web-platform-tests PR 15179 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15179
Details from upstream follow.

Yao Xiao <yaoxia@chromium.org> wrote:

Add tentative WPT to verify download in sandbox

General testing idea:
For a network request, the server stores a token in stash.
And after a fixed period of time, we validate the token in the
stash to verify a download has happened. Also assert that no
additional navigation should happen.

In the case of \<a download> where the decision of download can be made
before resource fetching, the server sets the token immediately.

In the case of navigation to a download, the server will stream a
response over 1 seconds and set the token at the end only when the
socket has been connected. So it is able to detect any download
cancellation while fetching the resource.

Bug: 539938, 927183
Change-Id: I7b90d46504603f60938a46acee9fbd7d1483988b
Reviewed-on: https://chromium-review.googlesource.com/1446395
WPT-Export-Revision: 2b28dff60a4f6b25f512661a22d4717ce0beb7da

Assignee

Updated

3 months ago
Component: web-platform-tests → DOM
Product: Testing → Core
Assignee

Comment 3

3 months ago
Ran 4 tests and 4 subtests
OK     : 4
PASS   : 2
FAIL   : 2

New tests that have failures or other problems:
/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_anchor_download_block_downloads_without_user_activation.sub.tentative.html
    <a download> triggered download in sandbox is blocked.: FAIL
/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigation_download_block_downloads_without_user_activation.sub.tentative.html
    Navigation resulted download in sandbox is blocked.: FAIL
Component: DOM → DOM: Core & HTML
Product: Core → Core

Comment 5

2 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6caf4fe5691d
[wpt PR 15179] - Add tentative WPT to verify download in sandbox, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6ad6c137153
[wpt PR 15179] - Update wpt metadata, a=testonly

Comment 6

2 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/496fc0a8cd1d
[wpt PR 15179] - Add tentative WPT to verify download in sandbox, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2de5b064971
[wpt PR 15179] - Update wpt metadata, a=testonly

Comment 7

2 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.