Remove devtools.inspector.fonthighlighter.enabled pref

RESOLVED FIXED in Firefox 67

Status

enhancement
P3
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: gl, Assigned: rfgo, Mentored)

Tracking

({good-first-bug})

unspecified
Firefox 67

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

4 months ago

This bug is to remove all instances of the devtools.inspector.fonthighlighter.enabled pref. Since it is shipped and default to ON, we shouldn't need this check anymore. https://searchfox.org/mozilla-central/search?q=devtools.inspector.fonthighlighter.enabled&path=

Assignee

Comment 1

4 months ago

Hi, simple question but just to make sure I understand before tackling the bug, when you mean remove all instances you don't just mean just 'devtools.inspector.fonthighlighter.enabled.pref'but the entire line containing it.

For example for below:

pref("devtools.inspector.fonthighlighter.enabled", true);

I would just delete all of it?

Reporter

Comment 2

4 months ago

(In reply to Rainier Go [:rfgo] from comment #1)

Hi, simple question but just to make sure I understand before tackling the bug, when you mean remove all instances you don't just mean just 'devtools.inspector.fonthighlighter.enabled.pref'but the entire line containing it.

For example for below:

pref("devtools.inspector.fonthighlighter.enabled", true);

I would just delete all of it?

Hi Rainier, you can remove the entire line for that example. Afterwards, any instances of devtools.inspector.fonthighlighter.enabled should be removed. For example, https://searchfox.org/mozilla-central/search?q=symbol:%23FONT_HIGHLIGHTER_PREF&redirect=false

Assignee

Comment 3

4 months ago

Sorry so for that example, if I delete the first line wouldn't it cause an error because the variable is being used in the argument?

const FONT_HIGHLIGHTER_PREF = "devtools.inspector.fonthighlighter.enabled";

if (Services.prefs.getBoolPref(FONT_HIGHLIGHTER_PREF)) {

Reporter

Comment 4

4 months ago

(In reply to Rainier Go [:rfgo] from comment #3)

Sorry so for that example, if I delete the first line wouldn't it cause an error because the variable is being used in the argument?

const FONT_HIGHLIGHTER_PREF = "devtools.inspector.fonthighlighter.enabled";

if (Services.prefs.getBoolPref(FONT_HIGHLIGHTER_PREF)) {

Yes if you delete FONT_HIGHLIGHTER_PREF, you would go about removing that if statement now since we don't need to check that pref anymore.

Reporter

Updated

4 months ago
Mentor: gl
Assignee

Comment 5

4 months ago

Great! Thank you. I'll go ahead and do this then.

Comment 7

4 months ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43dea2157ab5
Remove devtools.inspector.fonthighlighter.enabled pref. r=gl
Reporter

Updated

4 months ago
Assignee: nobody → rainier.f.go
Status: NEW → ASSIGNED

Comment 8

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.