Closed Bug 1529468 Opened 1 year ago Closed 1 year ago

Remove devtools.inspector.fonthighlighter.enabled pref

Categories

(DevTools :: Inspector: Fonts, enhancement, P3)

enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: gl, Assigned: rfgo, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

This bug is to remove all instances of the devtools.inspector.fonthighlighter.enabled pref. Since it is shipped and default to ON, we shouldn't need this check anymore. https://searchfox.org/mozilla-central/search?q=devtools.inspector.fonthighlighter.enabled&path=

Hi, simple question but just to make sure I understand before tackling the bug, when you mean remove all instances you don't just mean just 'devtools.inspector.fonthighlighter.enabled.pref'but the entire line containing it.

For example for below:

pref("devtools.inspector.fonthighlighter.enabled", true);

I would just delete all of it?

(In reply to Rainier Go [:rfgo] from comment #1)

Hi, simple question but just to make sure I understand before tackling the bug, when you mean remove all instances you don't just mean just 'devtools.inspector.fonthighlighter.enabled.pref'but the entire line containing it.

For example for below:

pref("devtools.inspector.fonthighlighter.enabled", true);

I would just delete all of it?

Hi Rainier, you can remove the entire line for that example. Afterwards, any instances of devtools.inspector.fonthighlighter.enabled should be removed. For example, https://searchfox.org/mozilla-central/search?q=symbol:%23FONT_HIGHLIGHTER_PREF&redirect=false

Sorry so for that example, if I delete the first line wouldn't it cause an error because the variable is being used in the argument?

const FONT_HIGHLIGHTER_PREF = "devtools.inspector.fonthighlighter.enabled";

if (Services.prefs.getBoolPref(FONT_HIGHLIGHTER_PREF)) {

(In reply to Rainier Go [:rfgo] from comment #3)

Sorry so for that example, if I delete the first line wouldn't it cause an error because the variable is being used in the argument?

const FONT_HIGHLIGHTER_PREF = "devtools.inspector.fonthighlighter.enabled";

if (Services.prefs.getBoolPref(FONT_HIGHLIGHTER_PREF)) {

Yes if you delete FONT_HIGHLIGHTER_PREF, you would go about removing that if statement now since we don't need to check that pref anymore.

Mentor: gl

Great! Thank you. I'll go ahead and do this then.

Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43dea2157ab5
Remove devtools.inspector.fonthighlighter.enabled pref. r=gl
Assignee: nobody → rainier.f.go
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.