1529468 - Remove devtools.inspector.fonthighlighter.enabled pref

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Gabriel [:gl] (ΦωΦ)]

This bug is to remove all instances of the devtools.inspector.fonthighlighter.enabled pref. Since it is shipped and default to ON, we shouldn't need this check anymore. https://searchfox.org/mozilla-central/search?q=devtools.inspector.fonthighlighter.enabled&path=

Comment 1

[Rainier Go [:rfgo]]

Hi, simple question but just to make sure I understand before tackling the bug, when you mean remove all instances you don't just mean just 'devtools.inspector.fonthighlighter.enabled.pref'but the entire line containing it.

For example for below:

pref("devtools.inspector.fonthighlighter.enabled", true);

I would just delete all of it?

Comment 2

[Gabriel [:gl] (ΦωΦ)]

(In reply to Rainier Go [:rfgo] from comment #1)

Hi, simple question but just to make sure I understand before tackling the bug, when you mean remove all instances you don't just mean just 'devtools.inspector.fonthighlighter.enabled.pref'but the entire line containing it.

For example for below:

pref("devtools.inspector.fonthighlighter.enabled", true);

I would just delete all of it?

Hi Rainier, you can remove the entire line for that example. Afterwards, any instances of devtools.inspector.fonthighlighter.enabled should be removed. For example, https://searchfox.org/mozilla-central/search?q=symbol:%23FONT_HIGHLIGHTER_PREF&redirect=false

Comment 3

[Rainier Go [:rfgo]]

Sorry so for that example, if I delete the first line wouldn't it cause an error because the variable is being used in the argument?

const FONT_HIGHLIGHTER_PREF = "devtools.inspector.fonthighlighter.enabled";

if (Services.prefs.getBoolPref(FONT_HIGHLIGHTER_PREF)) {

Comment 4

[Gabriel [:gl] (ΦωΦ)]

(In reply to Rainier Go [:rfgo] from comment #3)

Sorry so for that example, if I delete the first line wouldn't it cause an error because the variable is being used in the argument?

const FONT_HIGHLIGHTER_PREF = "devtools.inspector.fonthighlighter.enabled";

if (Services.prefs.getBoolPref(FONT_HIGHLIGHTER_PREF)) {

Yes if you delete FONT_HIGHLIGHTER_PREF, you would go about removing that if statement now since we don't need to check that pref anymore.

Comment 5

[Rainier Go [:rfgo]]

Great! Thank you. I'll go ahead and do this then.

Comment 6

[Rainier Go [:rfgo]]

Attachment: Bug 1529468 - Removed all instances of 'devtools.inspector.fonthighlighter.enabled'

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43dea2157ab5
Remove devtools.inspector.fonthighlighter.enabled pref. r=gl

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/43dea2157ab5