Closed
Bug 1529504
Opened 5 years ago
Closed 5 years ago
Fix two flake8 warnings
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement, P5)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox67 fixed)
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: alvaroserero)
References
Details
Attachments
(1 file)
|
1.15 KB,
patch
|
Sylvestre
:
review+
|
Details | Diff | Splinter Review |
Exercise for an intern
We are getting "is assigned to but never used" on both lines:
https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/mach_commands.py#1622
https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/mach_commands.py#2471
|
Assignee | |
Comment 1•5 years ago
|
||
Attachment #9045620 -
Flags: review?(sledru)
|
Reporter | |
Updated•5 years ago
|
Assignee: nobody → alvaroserero
|
|
Reporter | |
Comment 2•5 years ago
|
||
Comment on attachment 9045620 [details] [diff] [review] delete unusual parts. A few changes should be made: * remove the empty line before self._warnings * check that clang_output is indeed changed by finditer (maybe the whole line is useless)
Attachment #9045620 -
Flags: review?(sledru) → review+
|
|
Reporter | |
Comment 3•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a96d8f9339f49e84789bbe3899699c5d7185406 Bug 1529504 - Fix two flake8 warnings in static analysis (mach_commands.py) r=sylvestre
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
|
|
Reporter | |
Updated•5 years ago
|
Severity: normal → minor
Priority: -- → P5
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•