Closed Bug 1529615 Opened 2 years ago Closed 2 years ago

Don't try to scroll to bottom if the output does not overflow

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Details

Attachments

(1 file)

When recording profiles of console opening, I'm seeing scrollToBottom appear and taking some time, even if the console output is empty (14ms in this example ).

We shouldn't try to scroll to bottom if the output does not overflow

We are trying to scroll to the bottom on componentDidMount and
on message addition, even if the console output does not overflow.
Since scrollToBottom can take a dozen ms (or more), we should
avoid to call it when there's no need to.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a52513df092
Don't scroll to bottom if there's no need to; r=Honza.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.