Don't try to scroll to bottom if the output does not overflow

RESOLVED FIXED in Firefox 67

Status

enhancement
P1
normal
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Tracking

Trunk
Firefox 67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

When recording profiles of console opening, I'm seeing scrollToBottom appear and taking some time, even if the console output is empty (14ms in this example ).

We shouldn't try to scroll to bottom if the output does not overflow

We are trying to scroll to the bottom on componentDidMount and
on message addition, even if the console output does not overflow.
Since scrollToBottom can take a dozen ms (or more), we should
avoid to call it when there's no need to.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a52513df092
Don't scroll to bottom if there's no need to; r=Honza.
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.