Closed Bug 1529619 Opened 1 year ago Closed 1 year ago

Coverity gets confused about the null check inside nsCSSFrameConstructor::BeginBuildingScrollFrame()

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This null check https://searchfox.org/mozilla-central/rev/4587d146681b16ff9878a6fdcba53b04f76abe1d/layout/base/nsCSSFrameConstructor.cpp#4192 makes Coverity think gfxScrollFrame can be null here and is dereferenced on line 4184 without a null check. This is of course a mistake due to lines 4154 and 4159.

Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df386be1a93c
Remove a needless null check from nsCSSFrameConstructor::BeginBuildingScrollFrame() which confuses Coverity; r=emilio
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.