Closed Bug 1529619 Opened 5 years ago Closed 5 years ago

Coverity gets confused about the null check inside nsCSSFrameConstructor::BeginBuildingScrollFrame()

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1529619 - Remove a needless null check from nsCSSFrameConstructor::BeginBuildingScrollFrame() which confuses Coverity;
47 bytes, text/x-phabricator-request
Details | Review

This null check https://searchfox.org/mozilla-central/rev/4587d146681b16ff9878a6fdcba53b04f76abe1d/layout/base/nsCSSFrameConstructor.cpp#4192 makes Coverity think gfxScrollFrame can be null here and is dereferenced on line 4184 without a null check. This is of course a mistake due to lines 4154 and 4159.

Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df386be1a93c
Remove a needless null check from nsCSSFrameConstructor::BeginBuildingScrollFrame() which confuses Coverity; r=emilio

https://hg.mozilla.org/mozilla-central/rev/df386be1a93c

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → ehsan
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: