Closed
Bug 1529635
Opened 5 years ago
Closed 5 years ago
RTCIceCandidate constructor validation for sdpMid/sdpMLineIndex is not implemented
Categories
(Core :: WebRTC: Signaling, enhancement, P2)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: bwc, Assigned: bwc)
References
Details
Attachments
(2 files)
Spec says we need to verify that at least one of sdpMid and sdpMLineIndex need to be set in the constructor for RTCIceCandidate. We do this sort of checking in addIceCandidate, but that's too late according to spec.
Priority: -- → P2
|
||
Comment 1•5 years ago
|
||
We do this sort of checking in addIceCandidate, but that's too late according to spec.
FWIW the spec also says to do it there, so we shouldn't remove it. We need to do it in both places, because addIceCandidate takes a dictionary now.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → docfaraday
|
|
Assignee | |
Comment 2•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7edc0eeabb854eafa0868fb582ed3961b57d8634
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D23220
|
||
Updated•5 years ago
|
Attachment #9051382 -
Attachment description: Bug 1529635: Add sdpMid/sdpMLineIndex checking to RTCIceCandidate. r?jib → Bug 1529635 - Part 1: Add sdpMid/sdpMLineIndex checking to RTCIceCandidate. r?jib
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D23723
|
|
Assignee | |
Comment 5•5 years ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/703b266e3529 Part 1: Add sdpMid/sdpMLineIndex checking to RTCIceCandidate. r=jib https://hg.mozilla.org/integration/autoland/rev/5e2514122d46 Part 2: Fix a couple of bug links that should have been updated in bug 1490658. r=jib
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/703b266e3529
https://hg.mozilla.org/mozilla-central/rev/5e2514122d46
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•