1529646 - WPT webrtc/RTCIceCandidate-constructor.html is wrong about why {candidate: null} throws TypeError

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Byron Campen [:bwc]]

See this fiddle: https://jsfiddle.net/as6hex5y/1/

I think the relevant part of the spec is here: https://heycam.github.io/webidl/#es-dictionary

Note that using undefined instead of null elicits the expected TypeError

Comment 1

[Byron Campen [:bwc]]

Maybe this is just a wrinkle caused by the fact that null can be converted to a DOMString?

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I think the relevant part of the spec is here: https://heycam.github.io/webidl/#es-dictionary

I don't see it saying this should throw. This constructor takes an optional RTCIceCandidateInit dictionary, whose optional candidate member has a default value of "".

• If Type(esDict) is NOT Undefined, Null or Object, then throw a TypeError.

Type of {candidate: null} (that is: the outer {}) is object, so proceed:

• ...(skipping additional irrelevant checks on esDict)...
• If esMemberValue is not undefined, then:
  • Let idlMemberValue be the result of converting esMemberValue to an IDL value whose type is the type member is declared to be of.

Where converting for DOMString takes us to toString which says: Return "null".

So it appears to me https://github.com/web-platform-tests/wpt/blob/master/webrtc/RTCIceCandidate-constructor.html#L59 is wrong.

Comment 3

[Byron Campen [:bwc]]

It looks like this is the source of our problem:

https://searchfox.org/mozilla-central/rev/aae527894a97ee3bbe0c2cfce9c67c59e8b8fcb9/dom/media/PeerConnection.jsm#1127

Which is necessitated by this:

https://searchfox.org/mozilla-central/source/dom/webidl/PeerConnectionImpl.webidl#95

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1529646 - Fix mistaken claim in web-platform/tests/webrtc/RTCIceCandidate-constructor.html. r?bwc

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0375b7d9182
Fix mistaken claim in web-platform/tests/webrtc/RTCIceCandidate-constructor.html. r=bwc

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45261 for changes under testing/web-platform/tests

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a0375b7d9182

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot