1529700 - Remove unused 'blur' event listener from password manager

Status: RESOLVED INVALID

(Toolkit :: Password Manager, enhancement, P3)

Description

[Matthew N. [:MattN]]

We currently only listen to blur on the window but since that doesn't bubble it's not doing what is expected, which is to handle blurring the username field.

The DOMAutoComplete event already handles hitting Enter or Tab in a username field.

I tried to remove this from desktop (I already removed it on Android) in bug 1304001 comment 8 but it got backed out for failures in dom/html/test/test_bug430351.html like:

TEST-UNEXPECTED-FAIL | dom/html/test/test_bug430351.html | <iframe xmlns="http://www.w3.org/1999/xhtml"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="parent"><iframe></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1304001 - Remove unused 'blur' event listener. r=sfoster

The blur event doesn't bubble so this wouldn't actually listen to fields getting blurred. See bug 1138774.

Comment 2

[Phabricator Automation]

Comment on attachment 9045753 [details]
Bug 1304001 - Remove unused 'blur' event listener. r=sfoster

Revision D20396 was moved to bug 1304001. Setting attachment 9045753 [details] to obsolete.

Comment 3

[Matthew N. [:MattN]]

attachment 9045753 [details] wasn't the cause of the test failure after all.