Closed Bug 1529752 Opened 11 months ago Closed 10 months ago

[wpt-sync] Sync PR 15423 - Added calc-serialization-002 getComputedStyle-border-radius-002 tests

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15423 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15423
Details from upstream follow.

Gérard Talbot <github@gtalbot.org> wrote:

Added calc-serialization-002 getComputedStyle-border-radius-002 tests

This replaces pull request 14987
https://github.com/web-platform-tests/wpt/pull/14987
which corrects and improves the mentioned tests.

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 2 tests and 19 subtests
OK     : 2
PASS   : 9
FAIL   : 10

New tests that have failures or other problems:
/css/css-values/calc-serialization-002.html
    testing calc(1em + 1.27cm + 13% + 3em): FAIL
    testing calc(25.4q + 1vh + 12%): FAIL
/css/css-values/getComputedStyle-border-radius-002.html
    percentage conversion test 5: FAIL
    percentage conversion test 6: FAIL
    percentage conversion test 7: FAIL
    percentage conversion test 8: FAIL
    simple percentage conversion test 1: FAIL
    simple percentage conversion test 2: FAIL
    simple percentage conversion test 3: FAIL
    simple percentage conversion test 4: FAIL

(In reply to Web Platform Test Sync Bot from comment #3)

Ran 2 tests and 19 subtests
OK : 2
PASS : 9
FAIL : 10

New tests that have failures or other problems:
/css/css-values/calc-serialization-002.html
testing calc(1em + 1.27cm + 13% + 3em): FAIL
testing calc(25.4q + 1vh + 12%): FAIL

Right now calc-serialization-002.html test can NOT be considered as valid or reliable or trustworthy. There is a need to clarify the specification with regards to how serialization should be performed on specified values with various units. I explained this here:

https://github.com/web-platform-tests/wpt/pull/15423#issuecomment-464820174

/css/css-values/getComputedStyle-border-radius-002.html
percentage conversion test 5: FAIL
percentage conversion test 6: FAIL
percentage conversion test 7: FAIL
percentage conversion test 8: FAIL
simple percentage conversion test 1: FAIL
simple percentage conversion test 2: FAIL
simple percentage conversion test 3: FAIL
simple percentage conversion test 4: FAIL

getComputedStyle-border-radius-002.html test, on the other hand, is reliable and trustworthy and Firefox 67 PASSES these 8 conversion tests as witnessed by these test result:

https://wpt.fyi/results/css/css-values/getComputedStyle-border-radius-002.html?label=master

Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b5d77924a13
[wpt PR 15423] - Added calc-serialization-002  getComputedStyle-border-radius-002 tests, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbf69465f685
[wpt PR 15423] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3529a19307c6
[wpt PR 15423] - Added calc-serialization-002  getComputedStyle-border-radius-002 tests, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/aff06f0ab5f8
[wpt PR 15423] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.